Re: [PATCH] ASoC: cs35l56: Support clock stop mode 1 if enabled in ACPI

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 11/03/2026 3:50 pm, Mark Brown wrote:
> On Wed, Mar 11, 2026 at 03:34:54PM +0000, Richard Fitzgerald wrote:
>> On 11/03/2026 3:30 pm, Mark Brown wrote:
> 
>>> Hrm, OK - the property seems to be confusingly named and defined :(  Can
>>> it have any values other than 0 and 1?
> 
>> It's part of the SoundWire spec. We have to follow it.
> 
>> The current spec says:
> 
>> mipi-sdw-clock-stop-mode1-supported
>> This optional Boolean Property shall indicate whether or not Clock-stop
>> is supported on this Device.
>> Integer (Boolean)
>> Values:
>> False (zero): Clock-stop mode1 is not supported on this Device.
>> True (nonzero): Clock-stop mode1 is supported on this Device.
> 
> Oh dear, cute enterprise nonsense hacks :(

The ACPI spec says that each property must be a {key,value} pair.

If you always need a value there's the possibility that someone will
create it with value 0 and expect that to mean false. So relying on its
presence to indicate true is dodgy, safer to define that the value
has meaning.