Missing signoff in the bpf tree

Missing signoff in the bpf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

Commits

  4499609f99fd5 ("selftests/bpf: Test global subprog callback contexts")
  3506b9a2f1085 ("bpf: Verify global subprogs in each sleepability context")

are missing a Signed-off-by from their committers

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the bpf tree

[Kumar Kartikeya Dwivedi]

+To Eduard

On Thu Sep 17, 2026 at 12:30 PM CEST, Mark Brown wrote:
> Commits
>
>   4499609f99fd5 ("selftests/bpf: Test global subprog callback contexts")
>   3506b9a2f1085 ("bpf: Verify global subprogs in each sleepability context")
>
> are missing a Signed-off-by from their committers

Re: Missing signoff in the bpf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Thu, Sep 17, 2026 at 12:59:30PM +0200, Kumar Kartikeya Dwivedi wrote:
> +To Eduard
> 
> On Thu Sep 17, 2026 at 12:30 PM CEST, Mark Brown wrote:
> > Commits
> >
> >   4499609f99fd5 ("selftests/bpf: Test global subprog callback contexts")
> >   3506b9a2f1085 ("bpf: Verify global subprogs in each sleepability context")
> >
> > are missing a Signed-off-by from their committers

Does the contacts list for the BPF trees need to be updated?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the bpf tree

[Kumar Kartikeya Dwivedi]

On Thu Sep 17, 2026 at 1:09 PM CEST, Mark Brown wrote:
> On Thu, Sep 17, 2026 at 12:59:30PM +0200, Kumar Kartikeya Dwivedi wrote:
>> +To Eduard
>>
>> On Thu Sep 17, 2026 at 12:30 PM CEST, Mark Brown wrote:
>> > Commits
>> >
>> >   4499609f99fd5 ("selftests/bpf: Test global subprog callback contexts")
>> >   3506b9a2f1085 ("bpf: Verify global subprogs in each sleepability context")
>> >
>> > are missing a Signed-off-by from their committers
>
> Does the contacts list for the BPF trees need to be updated?

Well, he's the committer, so makes sense to put him in the recipients as well :).
Once he gets to this he can probably force push to correct it, I guess.

Re: Missing signoff in the bpf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

On Thu, Sep 17, 2026 at 01:20:11PM +0200, Kumar Kartikeya Dwivedi wrote:
> On Thu Sep 17, 2026 at 1:09 PM CEST, Mark Brown wrote:

> > Does the contacts list for the BPF trees need to be updated?

> Well, he's the committer, so makes sense to put him in the recipients as well :).
> Once he gets to this he can probably force push to correct it, I guess.

Do you have a full list of the current committers, I guess there's been
more bitrot than just this?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the bpf tree

[Kumar Kartikeya Dwivedi]

On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:
> On Thu, Sep 17, 2026 at 01:20:11PM +0200, Kumar Kartikeya Dwivedi wrote:
>> On Thu Sep 17, 2026 at 1:09 PM CEST, Mark Brown wrote:
>
>> > Does the contacts list for the BPF trees need to be updated?
>
>> Well, he's the committer, so makes sense to put him in the recipients as well :).
>> Once he gets to this he can probably force push to correct it, I guess.
>
> Do you have a full list of the current committers, I guess there's been
> more bitrot than just this?

It's me and Eduard, apart from Alexei, Daniel, and Andrii.

Re: Missing signoff in the bpf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

On Thu, Sep 17, 2026 at 01:27:01PM +0200, Kumar Kartikeya Dwivedi wrote:
> On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:

> > Do you have a full list of the current committers, I guess there's been
> > more bitrot than just this?

> It's me and Eduard, apart from Alexei, Daniel, and Andrii.

I've added you and Eduard.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the bpf tree

[Eduard Zingerman]

On Thu, 2026-09-17 at 16:03 +0100, Mark Brown wrote:
> On Thu, Sep 17, 2026 at 01:27:01PM +0200, Kumar Kartikeya Dwivedi wrote:
> > On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:
> 
> > > Do you have a full list of the current committers, I guess there's been
> > > more bitrot than just this?
> 
> > It's me and Eduard, apart from Alexei, Daniel, and Andrii.
> 
> I've added you and Eduard.

Apologies, that's on me, some issue with scripts configuration again.
What would you like me to do? Force push with SOBs?

Re: Missing signoff in the bpf tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

On Thu, Sep 17, 2026 at 10:08:38AM -0700, Eduard Zingerman wrote:
> On Thu, 2026-09-17 at 16:03 +0100, Mark Brown wrote:
> > On Thu, Sep 17, 2026 at 01:27:01PM +0200, Kumar Kartikeya Dwivedi wrote:
> > > On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:

> > > > Do you have a full list of the current committers, I guess there's been
> > > > more bitrot than just this?

> > > It's me and Eduard, apart from Alexei, Daniel, and Andrii.

> > I've added you and Eduard.

> Apologies, that's on me, some issue with scripts configuration again.
> What would you like me to do? Force push with SOBs?

There's no problem I noticed with the tree - this is about making sure
the list of people who I contact when there's issues with the tree
includes all the committers.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoff in the bpf tree

[Andrii Nakryiko]

On Thu, Sep 17, 2026 at 10:08 AM Eduard Zingerman <eddyz87@gmail.com> wrote:
>
> On Thu, 2026-09-17 at 16:03 +0100, Mark Brown wrote:
> > On Thu, Sep 17, 2026 at 01:27:01PM +0200, Kumar Kartikeya Dwivedi wrote:
> > > On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:
> >
> > > > Do you have a full list of the current committers, I guess there's been
> > > > more bitrot than just this?
> >
> > > It's me and Eduard, apart from Alexei, Daniel, and Andrii.
> >
> > I've added you and Eduard.
>
> Apologies, that's on me, some issue with scripts configuration again.
> What would you like me to do? Force push with SOBs?

rebase preserving merges, and add your SOB for all commits that you
rebased, including "xsk: Use a 32-bit compare in xsk_map_gen_lookup"
which you didn't apply, you still need to add your SOB

Re: Missing signoff in the bpf tree

[Eduard Zingerman]

On Thu, 2026-09-17 at 10:27 -0700, Andrii Nakryiko wrote:
> On Thu, Sep 17, 2026 at 10:08 AM Eduard Zingerman <eddyz87@gmail.com> wrote:
> > 
> > On Thu, 2026-09-17 at 16:03 +0100, Mark Brown wrote:
> > > On Thu, Sep 17, 2026 at 01:27:01PM +0200, Kumar Kartikeya Dwivedi wrote:
> > > > On Thu Sep 17, 2026 at 1:23 PM CEST, Mark Brown wrote:
> > > 
> > > > > Do you have a full list of the current committers, I guess there's been
> > > > > more bitrot than just this?
> > > 
> > > > It's me and Eduard, apart from Alexei, Daniel, and Andrii.
> > > 
> > > I've added you and Eduard.
> > 
> > Apologies, that's on me, some issue with scripts configuration again.
> > What would you like me to do? Force push with SOBs?
> 
> rebase preserving merges, and add your SOB for all commits that you
> rebased, including "xsk: Use a 32-bit compare in xsk_map_gen_lookup"
> which you didn't apply, you still need to add your SOB

Done.
Apologies for inconvenience.
Andrii, thank you for the instructions.