mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rohit Jain <rohit.k.jain@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
	vincent.guittot@linaro.org, morten.rasmussen@arm.com,
	dietmar.eggemann@arm.com, Dhaval Giani <dhaval.giani@oracle.com>
Subject: Re: [PATCH] sched: Introduce scaled capacity awareness in enqueue
Date: Mon, 5 Jun 2017 11:08:38 -0700	[thread overview]
Message-ID: <6a613277-8e2c-4c05-1420-b288d15a036b@oracle.com> (raw)
In-Reply-To: <20170602182621.gnpjs4fpvwze2hfr@hirez.programming.kicks-ass.net>

On 06/02/2017 11:26 AM, Peter Zijlstra wrote:
> On Fri, Jun 02, 2017 at 11:20:20AM -0700, Rohit Jain wrote:
>> On 06/01/2017 05:37 AM, Peter Zijlstra wrote:
>>> On Thu, Jun 01, 2017 at 02:28:27PM +0200, Peter Zijlstra wrote:
>>>> On Wed, May 31, 2017 at 03:19:46PM -0700, Rohit Jain wrote:
>>>>
>>>>>>> 2) This scaled capacity is normalized and mapped into buckets.
>>>>>> Why?
>>> And its not at all clear why you'd need
>>> that to begin with.
>> Here is the problem I am trying to solve:
>>
>> The benchmark(s) have a high degree of variance when run multiple
>> times.
>>
>> We believe it is because of the scheduler not being aware of the scaled
>> down capacity of the CPUs because of IRQ/RT activity.
>>
>> This patch helps in solving the above problem. Do you have any thoughts
>> on solving this problem in any other way?
> Why does determining if a CPU's capacity is scaled down need to involve
> global data? AFAICT its a purely CPU local affair.

The global array is used to determine the threshold capacity, so
that any CPU which lies below decides that a CPU is 'running low' on
available capacity. This threshold can also be statically defined to
be a fixed fraction, but having dynamic calculation to determine the
threshold works for all benchmarks.

Did you mean we should use a static cutoff and decide whether a CPU
should be treated low on capacity and skip it during idle CPU search?

  reply	other threads:[~2017-06-05 18:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 20:48 Rohit Jain
2017-05-30 12:28 ` Peter Zijlstra
2017-05-31 22:19   ` Rohit Jain
2017-06-01 12:28     ` Peter Zijlstra
2017-06-01 12:37       ` Peter Zijlstra
2017-06-02 18:20         ` Rohit Jain
2017-06-02 18:26           ` Peter Zijlstra
2017-06-05 18:08             ` Rohit Jain [this message]
2017-06-12 15:36               ` Peter Zijlstra
2017-06-13  0:31                 ` Rohit Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a613277-8e2c-4c05-1420-b288d15a036b@oracle.com \
    --to=rohit.k.jain@oracle.com \
    --cc=dhaval.giani@oracle.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®