From: Peter Zijlstra <peterz@infradead.org>
To: Rohit Jain <rohit.k.jain@oracle.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
vincent.guittot@linaro.org, morten.rasmussen@arm.com,
dietmar.eggemann@arm.com
Subject: Re: [PATCH] sched: Introduce scaled capacity awareness in enqueue
Date: Thu, 1 Jun 2017 14:37:45 +0200 [thread overview]
Message-ID: <20170601123745.llebc4ur23d7t4fw@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170601122827.5ptc3n47vvk2y7k7@hirez.programming.kicks-ass.net>
On Thu, Jun 01, 2017 at 02:28:27PM +0200, Peter Zijlstra wrote:
> On Wed, May 31, 2017 at 03:19:46PM -0700, Rohit Jain wrote:
>
> > > > 2) This scaled capacity is normalized and mapped into buckets.
> > > Why?
> >
> > This is done to deterministically define the CPUs which are low on
> > capacities. By mapping it into buckets it becomes easier to do a
> > percentile calculation.
>
> *sigh*, you're really going to make me read and reverse engineer your
> horrible code.. :/
Blergh, I can't be arsed. It's got horrible style, its stuffed into the
loadavg code even though its completely unrelated to that particular
trainwreck and it adds more global state.
Global state is bad, very bad. And its not at all clear why you'd need
that to begin with.
next prev parent reply other threads:[~2017-06-01 12:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 20:48 Rohit Jain
2017-05-30 12:28 ` Peter Zijlstra
2017-05-31 22:19 ` Rohit Jain
2017-06-01 12:28 ` Peter Zijlstra
2017-06-01 12:37 ` Peter Zijlstra [this message]
2017-06-02 18:20 ` Rohit Jain
2017-06-02 18:26 ` Peter Zijlstra
2017-06-05 18:08 ` Rohit Jain
2017-06-12 15:36 ` Peter Zijlstra
2017-06-13 0:31 ` Rohit Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170601123745.llebc4ur23d7t4fw@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=rohit.k.jain@oracle.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®