From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
iommu@lists.linux.dev, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v11 0/9] media: iris: Add support for glymur platform
Date: Fri, 18 Sep 2026 09:00:55 +0200 [thread overview]
Message-ID: <6a7a5ad3-d33f-4921-997e-216b0c40b110@kernel.org> (raw)
In-Reply-To: <ad600338-dc87-dcc4-f1c9-8cbd53a1dc46@oss.qualcomm.com>
On 18/09/2026 08:57, Vishnu Reddy wrote:
>
> On 9/17/2026 12:41 PM, Krzysztof Kozlowski wrote:
>> On 17/09/2026 09:09, Krzysztof Kozlowski wrote:
>>> On Thu, Sep 17, 2026 at 10:30:19AM +0530, Vishnu Reddy wrote:
>>>> ---
>>>> Mukesh Ojha (1):
>>>> media: iris: Enable Secure PAS support with IOMMU managed by Linux
>>>>
>>>> Vishnu Reddy (8):
>>>> dt-bindings: media: qcom,glymur-iris: Add glymur video codec
>>>> media: iris: Replace enum-indexed clock and power domain tables with per-block structures
>>>> media: iris: Add power sequence for glymur
>>>> media: iris: Handle CPU_CS_SCIACMDARG3 register write via program bootup registers hook
>>>> media: iris: Add support to select core for dual core platforms
>>>> media: iris: Add platform data for glymur
>>>> arm64: dts: qcom: glymur: Add iris video node
>>>> arm64: dts: qcom: glymur-crd: Enable iris video codec node
>>>>
>>>> .../bindings/media/qcom,glymur-iris.yaml | 218 +++++++++++++++++++++
>>>> .../bindings/media/qcom,sm8550-iris.yaml | 6 +
>>>> .../bindings/media/qcom,sm8750-iris.yaml | 6 +
>>>> .../bindings/media/qcom,venus-common.yaml | 11 +-
>>>> arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 10 +
>>>> arch/arm64/boot/dts/qcom/glymur.dtsi | 120 ++++++++++++
>>>> drivers/media/platform/qcom/iris/Makefile | 1 +
>>>> drivers/media/platform/qcom/iris/iris_common.c | 10 +
>>>> drivers/media/platform/qcom/iris/iris_common.h | 1 +
>>>> drivers/media/platform/qcom/iris/iris_core.h | 32 ++-
>>>> drivers/media/platform/qcom/iris/iris_firmware.c | 69 +++++--
>>>> drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 +
>>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 19 ++
>>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 +
>>>> drivers/media/platform/qcom/iris/iris_instance.h | 2 +
>>>> .../platform/qcom/iris/iris_platform_common.h | 46 ++---
>>>> .../platform/qcom/iris/iris_platform_glymur.c | 78 ++++++++
>>>> .../platform/qcom/iris/iris_platform_glymur.h | 15 ++
>>>> .../platform/qcom/iris/iris_platform_sc7280.h | 28 ++-
>>>> .../platform/qcom/iris/iris_platform_sm8250.h | 26 ++-
>>>> .../platform/qcom/iris/iris_platform_sm8550.h | 26 ++-
>>>> .../platform/qcom/iris/iris_platform_sm8750.h | 29 ++-
>>>> .../media/platform/qcom/iris/iris_platform_vpu2.c | 20 +-
>>>> .../media/platform/qcom/iris/iris_platform_vpu3x.c | 67 ++++---
>>>> .../platform/qcom/iris/iris_platform_x1p42100.h | 27 ++-
>>>> drivers/media/platform/qcom/iris/iris_power.c | 20 +-
>>>> drivers/media/platform/qcom/iris/iris_probe.c | 153 +++++++++++++--
>>>> drivers/media/platform/qcom/iris/iris_resources.c | 81 ++++----
>>>> drivers/media/platform/qcom/iris/iris_resources.h | 8 +-
>>>> drivers/media/platform/qcom/iris/iris_utils.c | 58 ++++--
>>>> drivers/media/platform/qcom/iris/iris_utils.h | 3 +-
>>>> drivers/media/platform/qcom/iris/iris_vb2.c | 4 +
>>>> drivers/media/platform/qcom/iris/iris_vidc.c | 6 +-
>>>> drivers/media/platform/qcom/iris/iris_vpu3x.c | 216 +++++++++++++++++---
>>>> drivers/media/platform/qcom/iris/iris_vpu4x.c | 137 ++-----------
>>>> drivers/media/platform/qcom/iris/iris_vpu_common.c | 102 ++--------
>>>> drivers/media/platform/qcom/iris/iris_vpu_common.h | 3 +
>>>> .../platform/qcom/iris/iris_vpu_register_defines.h | 13 ++
>>>> 38 files changed, 1229 insertions(+), 444 deletions(-)
>>>> ---
>>>> base-commit: 0d9d0dbf2fddcff5859d623e90ca73c4054276e1
>>>> change-id: 20260917-glymur-627d049900e0
>>> Look here:
>>> https://lore.kernel.org/all/20260726-glymur-v10-0-de451559e88b@oss.qualcomm.com/
>>> change-id: 20260601-glymur-4fcd4d832ecc
>>>
>>> so now does this work?
>>> b4 diff '20260917-glymur-v11-1-e0c8bc914742@oss.qualcomm.com'
>>>
>>> No, it does not. You are sending bigger work, multi-version one, part of
>>> even bigger work, so please get the process working correct to make
>>> reviews easier.
>>>
>> And it is getting even better:
>> v6 change id was:
>> change-id: 20260515-glymur-6e69bc258fb0
>>
>> https://lore.kernel.org/all/20260515-glymur-v6-0-f6a99cb43a24@oss.qualcomm.com/
>>
>> ???
>
> Thank you for pointing this out. I lost my original workspace and had to
> recreate it, which unintentionally changed the Change-ID. I'll make sure
> to preserve the same Change-ID in further revisions.
You lost workspace three or four times? Go look at your previous
versions and count how many different change-ids there were...
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-18 7:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 5:00 Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 1/9] dt-bindings: media: qcom,glymur-iris: Add glymur video codec Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 2/9] media: iris: Enable Secure PAS support with IOMMU managed by Linux Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 3/9] media: iris: Replace enum-indexed clock and power domain tables with per-block structures Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 4/9] media: iris: Add power sequence for glymur Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 5/9] media: iris: Handle CPU_CS_SCIACMDARG3 register write via program bootup registers hook Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 6/9] media: iris: Add support to select core for dual core platforms Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 7/9] media: iris: Add platform data for glymur Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 8/9] arm64: dts: qcom: glymur: Add iris video node Vishnu Reddy
2026-09-17 5:00 ` [PATCH v11 9/9] arm64: dts: qcom: glymur-crd: Enable iris video codec node Vishnu Reddy
2026-09-17 7:09 ` [PATCH v11 0/9] media: iris: Add support for glymur platform Krzysztof Kozlowski
2026-09-17 7:11 ` Krzysztof Kozlowski
2026-09-18 6:57 ` Vishnu Reddy
2026-09-18 7:00 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7a5ad3-d33f-4921-997e-216b0c40b110@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=vikash.garodia@oss.qualcomm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®