mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, <jthumshirn@suse.de>,
	<mingo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: swim3: make of_device_ids const.
Date: Fri, 16 Jun 2017 09:49:33 -0600	[thread overview]
Message-ID: <6a9277be-97ac-ed74-d838-3e15719488f7@fb.com> (raw)
In-Reply-To: <c474c3c45e8b81dcb3420ca6a74564e6d37a9674.1497606536.git.arvind.yadav.cs@gmail.com>

On 06/16/2017 03:54 AM, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    8908	   1096	    624	  10628	   2984	drivers/block/swim3.o
> 
> File size after constify swim3_match:
>    text	   data	    bss	    dec	    hex	filename
>    9708	    296	    624	  10628	   2984	drivers/block/swim3.o

Applied, thanks.

-- 
Jens Axboe

      parent reply	other threads:[~2017-06-16 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-16  9:54 Arvind Yadav
2017-06-16 11:48 ` Johannes Thumshirn
2017-06-16 15:49 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a9277be-97ac-ed74-d838-3e15719488f7@fb.com \
    --to=axboe@fb.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®