* [PATCH] block: swim3: make of_device_ids const.
@ 2017-06-16 9:54 Arvind Yadav
2017-06-16 11:48 ` Johannes Thumshirn
2017-06-16 15:49 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Arvind Yadav @ 2017-06-16 9:54 UTC (permalink / raw)
To: jthumshirn, axboe, mingo; +Cc: linux-kernel
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
8908 1096 624 10628 2984 drivers/block/swim3.o
File size after constify swim3_match:
text data bss dec hex filename
9708 296 624 10628 2984 drivers/block/swim3.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/block/swim3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index ba4809c..7f72f8d 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -1245,7 +1245,7 @@ static int swim3_attach(struct macio_dev *mdev,
return 0;
}
-static struct of_device_id swim3_match[] =
+static const struct of_device_id swim3_match[] =
{
{
.name = "swim3",
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] block: swim3: make of_device_ids const.
2017-06-16 9:54 [PATCH] block: swim3: make of_device_ids const Arvind Yadav
@ 2017-06-16 11:48 ` Johannes Thumshirn
2017-06-16 15:49 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2017-06-16 11:48 UTC (permalink / raw)
To: Arvind Yadav; +Cc: jthumshirn, axboe, mingo, linux-kernel
On Fri, Jun 16, 2017 at 03:24:39PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8908 1096 624 10628 2984 drivers/block/swim3.o
>
> File size after constify swim3_match:
> text data bss dec hex filename
> 9708 296 624 10628 2984 drivers/block/swim3.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: swim3: make of_device_ids const.
2017-06-16 9:54 [PATCH] block: swim3: make of_device_ids const Arvind Yadav
2017-06-16 11:48 ` Johannes Thumshirn
@ 2017-06-16 15:49 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2017-06-16 15:49 UTC (permalink / raw)
To: Arvind Yadav, jthumshirn, mingo; +Cc: linux-kernel
On 06/16/2017 03:54 AM, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 8908 1096 624 10628 2984 drivers/block/swim3.o
>
> File size after constify swim3_match:
> text data bss dec hex filename
> 9708 296 624 10628 2984 drivers/block/swim3.o
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-16 15:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-16 9:54 [PATCH] block: swim3: make of_device_ids const Arvind Yadav
2017-06-16 11:48 ` Johannes Thumshirn
2017-06-16 15:49 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®