From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Marek Behún" <kabel@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU
Date: Tue, 11 Feb 2025 12:04:13 +0100 [thread overview]
Message-ID: <6aa243e1-6e25-46c8-b75a-d5e7bc1cd5a4@app.fastmail.com> (raw)
In-Reply-To: <077bd67861fe0ee246ba967a3406079373122439.1739271346.git.geert+renesas@glider.be>
On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> asking the user about these drivers when configuring a kernel that
> cannot run on an affected CZ.NIC Turris system.
>
> Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for
> Turris Omnia MCU")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Drop PPC_P2020 from the dependency list.
Looks good to me, one minor issue:
> @@ -6,6 +6,7 @@
>
> menuconfig CZNIC_PLATFORMS
> bool "Platform support for CZ.NIC's Turris hardware"
> + depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST
Technically the MACH_ARMADA_38X check is redundant here, as that
already requires ARCH_MVEBU.
Arnd
next prev parent reply other threads:[~2025-02-11 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 10:56 Geert Uytterhoeven
2025-02-11 11:04 ` Arnd Bergmann [this message]
2025-02-11 12:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aa243e1-6e25-46c8-b75a-d5e7bc1cd5a4@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=geert+renesas@glider.be \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®