[PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[Geert Uytterhoeven]

CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
asking the user about these drivers when configuring a kernel that
cannot run on an affected CZ.NIC Turris system.

Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for Turris Omnia MCU")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - Drop PPC_P2020 from the dependency list.
---
 drivers/platform/cznic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
index 49c383eb67854173..4134325cfcc2b916 100644
--- a/drivers/platform/cznic/Kconfig
+++ b/drivers/platform/cznic/Kconfig
@@ -6,6 +6,7 @@
 
 menuconfig CZNIC_PLATFORMS
 	bool "Platform support for CZ.NIC's Turris hardware"
+	depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST
 	help
 	  Say Y here to be able to choose driver support for CZ.NIC's Turris
 	  devices. This option alone does not add any kernel code.
-- 
2.43.0

Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[Arnd Bergmann]

On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> asking the user about these drivers when configuring a kernel that
> cannot run on an affected CZ.NIC Turris system.
>
> Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for 
> Turris Omnia MCU")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
>   - Drop PPC_P2020 from the dependency list.

Looks good to me, one minor issue:

> @@ -6,6 +6,7 @@
> 
>  menuconfig CZNIC_PLATFORMS
>  	bool "Platform support for CZ.NIC's Turris hardware"
> +	depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST

Technically the MACH_ARMADA_38X check is redundant here, as that
already requires ARCH_MVEBU.

     Arnd

Re: [PATCH v2] platform: cznic: CZNIC_PLATFORMS should depend on MACH_ARMADA_38X || ARCH_MVEBU

[Geert Uytterhoeven]

Hi Arnd,

On Tue, 11 Feb 2025 at 12:04, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Feb 11, 2025, at 11:56, Geert Uytterhoeven wrote:
> > CZ.NIC's Turris devices are based on Marvell Armada 385 or 3720 SoCs.
> > Hence add dependencies on MACH_ARMADA_38X and ARCH_MVEBU, to prevent
> > asking the user about these drivers when configuring a kernel that
> > cannot run on an affected CZ.NIC Turris system.
> >
> > Fixes: 992f1a3d4e88498d ("platform: cznic: Add preliminary support for
> > Turris Omnia MCU")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > v2:
> >   - Drop PPC_P2020 from the dependency list.
>
> Looks good to me, one minor issue:
>
> > @@ -6,6 +6,7 @@
> >
> >  menuconfig CZNIC_PLATFORMS
> >       bool "Platform support for CZ.NIC's Turris hardware"
> > +     depends on MACH_ARMADA_38X || ARCH_MVEBU || COMPILE_TEST
>
> Technically the MACH_ARMADA_38X check is redundant here, as that
> already requires ARCH_MVEBU.

Thanks for your comment!
Somehow I thought the former covers arm32, and the latter arm64,
but ARCH_MVEBU indeed covers both.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds