mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Mike Looijmans <mike.looijmans@topic.nl>, <linux-i2c@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: mux: pca954x: Add missing pca9546 definition to chip_desc
Date: Fri, 24 Mar 2017 12:21:58 +0100	[thread overview]
Message-ID: <6ad1df75-ceef-9b94-6c66-e6ba569221b4@axentia.se> (raw)
In-Reply-To: <1490259636-16859-1-git-send-email-mike.looijmans@topic.nl>

On 2017-03-23 10:00, Mike Looijmans wrote:
> The spec for the pca9546 was missing. This chip is the same as the pca9545
> except that it lacks interrupt lines. While the i2c_device_id table mapped
> the pca9546 to the pca9545 definition the compatible table did not.

Ouch, good catch, I have committed this to my i2c-mux for-current branch.

Cheers,
peda

> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
>  drivers/i2c/muxes/i2c-mux-pca954x.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index dfc1c0e..69c2f5a 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -117,6 +117,10 @@ struct pca954x {
>  		.has_irq = 1,
>  		.muxtype = pca954x_isswi,
>  	},
> +	[pca_9546] = {
> +		.nchans = 4,
> +		.muxtype = pca954x_isswi,
> +	},
>  	[pca_9547] = {
>  		.nchans = 8,
>  		.enable = 0x8,
> @@ -134,7 +138,7 @@ struct pca954x {
>  	{ "pca9543", pca_9543 },
>  	{ "pca9544", pca_9544 },
>  	{ "pca9545", pca_9545 },
> -	{ "pca9546", pca_9545 },
> +	{ "pca9546", pca_9546 },
>  	{ "pca9547", pca_9547 },
>  	{ "pca9548", pca_9548 },
>  	{ }
> 

      reply	other threads:[~2017-03-24 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  9:00 Mike Looijmans
2017-03-24 11:21 ` Peter Rosin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ad1df75-ceef-9b94-6c66-e6ba569221b4@axentia.se \
    --to=peda@axentia.se \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.looijmans@topic.nl \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®