[syzbot] [nvme?] WARNING in nvmet_fc_portentry_rebind_tgt

[syzbot] [nvme?] WARNING in nvmet_fc_portentry_rebind_tgt

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    4056b3c9d3c9 Merge tag 'nios2_update_for_v7.4' of git://gi..
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=14108235580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b38d39c45202f4fa
dashboard link: https://syzkaller.appspot.com/bug?extid=be62d4b375542ecebd17
compiler:       Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=16108235580000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+be62d4b375542ecebd17@syzkaller.appspotmail.com

------------[ cut here ]------------
pe->tgtport
WARNING: drivers/nvme/target/fc.c:1327 at nvmet_fc_portentry_rebind_tgt+0x1d7/0x1e0 drivers/nvme/target/fc.c:1327, CPU#1: syz-executor148/5937
Modules linked in:
CPU: 1 UID: 0 PID: 5937 Comm: syz-executor148 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/07/2026
RIP: 0010:nvmet_fc_portentry_rebind_tgt+0x1d7/0x1e0 drivers/nvme/target/fc.c:1327
Code: 6d 3d fc 48 8b 04 24 49 89 06 48 c7 c7 20 0f c8 8f 48 83 c4 18 5b 41 5c 41 5d 41 5e 41 5f 5d e9 3f ab 66 05 e8 ba a7 d0 fb 90 <0f> 0b 90 eb a6 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90
RSP: 0018:ffffc9000155fa78 EFLAGS: 00010293
RAX: ffffffff85f63196 RBX: dffffc0000000000 RCX: ffff888032880000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000001 R08: 0000000000000000 R09: 0000000000000000
R10: dffffc0000000000 R11: fffff520002abf40 R12: 1ffff1100741b8d0
R13: 0000000000000001 R14: ffff88803a0dc680 R15: ffff888012526800
FS:  00007f3c0db506c0(0000) GS:ffff888124abb000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3c0db4fff8 CR3: 0000000042756000 CR4: 00000000003526f0
Call Trace:
 <TASK>
 nvmet_fc_register_targetport+0x75a/0x950 drivers/nvme/target/fc.c:1417
 fcloop_create_target_port+0x135/0x4d0 drivers/nvme/target/fcloop.c:1558
 kernfs_fop_write_iter+0x3a5/0x540 fs/kernfs/file.c:345
 new_sync_write fs/read_write.c:595 [inline]
 vfs_write+0x61e/0xbb0 fs/read_write.c:687
 ksys_write+0x156/0x270 fs/read_write.c:739
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f3c0e3ae35e
Code: 08 0f 85 f5 e2 ff ff 49 89 fb 48 89 f0 48 89 d7 48 89 ce 4c 89 c2 4d 89 ca 4c 8b 44 24 08 4c 8b 4c 24 10 4c 89 5c 24 08 0f 05 <c3> 90 41 57 41 56 4d 89 c6 41 55 4d 89 cd 41 54 55 53 48 83 ec 08
RSP: 002b:00007f3c0db50118 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f3c0db506c0 RCX: 00007f3c0e3ae35e
RDX: 000000000000002f RSI: 00007f3c0e427b40 RDI: 0000000000000004
RBP: 00007f3c0e427b40 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffd0
R13: 0000000000000010 R14: 00007ffdb343b7d0 R15: 00007ffdb343b8b8
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Forwarded: nvmet-fc: skip port entry rebinding if already bound to a target port

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.

***

Subject: nvmet-fc: skip port entry rebinding if already bound to a target port
Author: neganhat@gmail.com

#syz test: upstream 4056b3c9d3c9

Re: [syzbot] [nvme?] WARNING in nvmet_fc_portentry_rebind_tgt

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+be62d4b375542ecebd17@syzkaller.appspotmail.com
Tested-by: syzbot+be62d4b375542ecebd17@syzkaller.appspotmail.com

Tested on:

commit:         4056b3c9 Merge tag 'nios2_update_for_v7.4' of git://gi..
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=164e1621580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=b38d39c45202f4fa
dashboard link: https://syzkaller.appspot.com/bug?extid=be62d4b375542ecebd17
compiler:       Debian clang version 22.1.8 (1~deb13u4), Debian LLD 22.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=17ede971580000

Note: testing is done by a robot and is best-effort only.