mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Thangaraj.S@microchip.com
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, Bryan.Whitehead@microchip.com,
	UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: lan743x: add RMII strap status detection for PCI11x1x
Date: Wed, 27 May 2026 14:12:28 +0200	[thread overview]
Message-ID: <6ae1c613-394c-46fe-a4cd-0ffa8cb0bffb@lunn.ch> (raw)
In-Reply-To: <DSWPR11MB97158A7DDD0C53EA9E221AE4EC082@DSWPR11MB9715.namprd11.prod.outlook.com>

> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> > 
> > > +     if (!adapter->is_sgmii_en && strap & STRAP_READ_USE_RMII_EN_) {
> > > +             if (strap & STRAP_READ_RMII_EN_)
> > > +                     adapter->is_rmii_en = true;
> > > +     }
> > 
> > What does it mean when both SGMII and RMII is strapped? What if neither
> > is strapped?
> [Thangaraj Samynathan] When both are enabled, Interface will SGMII. When
> Both are disabled interface will be RGMII.

So both enabled is not an error, we don't need to give a warning that
the board design is broken?

> > >       netif_dbg(adapter, drv, adapter->netdev,
> > >                 "SGMII I/F %sable\n", adapter->is_sgmii_en ? "En" :
> > > "Dis");
> > 
> > Since there is a netif_dbg() for sgmii, maybe add one for rmii, so the code is
> > somewhat symmetrical?
> [Thangaraj Samynathan] Sure. Will add it in the next revision. 

and maybe also add RGMII. Looking at this code, it is not obvious that
RGMII can be indicated by strapping.

	Andrew

  reply	other threads:[~2026-05-27 12:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 15:40 [PATCH net-next v2 0/2] net: lan743x: add RMII support " Thangaraj Samynathan
2026-05-26 15:40 ` [PATCH net-next v2 1/2] net: lan743x: add RMII strap status detection " Thangaraj Samynathan
2026-05-26 16:40   ` Andrew Lunn
2026-05-27  3:21     ` Thangaraj.S
2026-05-27 12:12       ` Andrew Lunn [this message]
2026-05-26 15:40 ` [PATCH net-next v2 2/2] net: lan743x: add support for RMII interface Thangaraj Samynathan
2026-05-26 16:49   ` Andrew Lunn
2026-05-26 19:59     ` Nicolai Buchwitz
2026-05-27 10:11       ` Nicolai Buchwitz
2026-05-27 12:20         ` Andrew Lunn
2026-05-27 12:38           ` Nicolai Buchwitz
2026-05-27  3:23     ` Thangaraj.S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ae1c613-394c-46fe-a4cd-0ffa8cb0bffb@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Bryan.Whitehead@microchip.com \
    --cc=Thangaraj.S@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®