Re: [PATCH net-next v2 2/2] net: lan743x: add support for RMII interface

[Nicolai Buchwitz <nb@tipi-net.de>]

On 27.5.2026 14:20, Andrew Lunn wrote:
> [...]

>> ksz_common is exactly that: it puts RMII in lpi_interfaces on purpose
>> and uses a dummy mac_enable_tx_lpi() (the comment there explains the 
>> HW
>> handles LPI itself once EEE is negotiated):

> [...]

> 
> and this is a 3rd variant, were you have an MAC/PHY pair which is
> tightly integrated. I doubt that RMII is actually being used, and the
> phy_interface_t should actually by "internal".

So, if we treat this as a special case, patch it and track LPI
internally ...

> 
>> So clearing RMII in phylink would break EEE there.
> 
> Agreed. So maybe it is too late to do this in the core, at least not
> without having to change some drivers.

... we could clear the bits in phylink when RMII is used? Arguably this
patch is the first occurrence of such a construct, but who knows what
the future will bring... Better be explicit in the framework than
rework it later?

> 	Andrew

Nicolai