From: Stefan Agner <stefan@agner.ch>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: shawn.guo@linaro.org, kernel@pengutronix.de,
jason@lakedaemon.net, marc.zyngier@arm.com,
linux@arm.linux.org.uk, u.kleine-koenig@pengutronix.de,
olof@lixom.net, arnd@arndb.de, daniel.lezcano@linaro.org,
mark.rutland@arm.com, pawel.moll@arm.com, robh+dt@kernel.org,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent
Date: Fri, 15 May 2015 18:01:19 +0200 [thread overview]
Message-ID: <6af49d55159182668c21480e0fbaa85c@agner.ch> (raw)
In-Reply-To: <alpine.DEB.2.11.1505151237531.4225@nanos>
On 2015-05-15 12:39, Thomas Gleixner wrote:
> On Sat, 9 May 2015, Stefan Agner wrote:
>> - irq_chip_unmask_parent(data);
>> + if (parent->chip->irq_enable)
>> + parent->chip->irq_enable(parent);
>> + else
>> + parent->chip->irq_unmask(parent);
>
> Why are you not creating irq_chip_enable_parent() which would have
> been the proper function anyway?
>
Will add that...
Btw, have you had a chance to look at 1/12? I added a helper there too
to allow make use of generic chip with IRQ domain hierarchy. In case you
are fine with that general appraoch I will send an updated version of
the patchset with the irq_chip_enable_parent helper soon.
--
Stefan
next prev parent reply other threads:[~2015-05-15 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:39 [PATCH v6 00/12] ARM: vf610m4: Add Vybrid Cortex-M4 support Stefan Agner
2015-05-09 20:39 ` [PATCH v6 01/12] irqdomain: Add non-hierarchy helper irq_domain_set_info Stefan Agner
2015-05-09 20:39 ` [PATCH v6 02/12] genirq: generic chip: support hierarchy domain Stefan Agner
2015-05-09 20:39 ` [PATCH v6 03/12] irqchip: nvic: support hierarchy irq domain Stefan Agner
2015-05-09 20:39 ` [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent Stefan Agner
2015-05-15 10:39 ` Thomas Gleixner
2015-05-15 16:01 ` Stefan Agner [this message]
2015-05-15 20:29 ` Thomas Gleixner
2015-05-09 20:39 ` [PATCH v6 05/12] ARM: ARMv7M: define size of vector table for Vybrid Stefan Agner
2015-05-09 20:39 ` [PATCH v6 06/12] clocksource: add dependencies for Vybrid pit clocksource Stefan Agner
2015-05-09 20:39 ` [PATCH v6 07/12] ARM: unify MMU/!MMU addruart calls Stefan Agner
2015-05-09 20:39 ` [PATCH v6 08/12] ARM: introduce ARM_SINGLE_ARMV7M for ARMv7-M platforms Stefan Agner
2015-05-09 20:39 ` [PATCH v6 09/12] ARM: efm32: use ARM_SINGLE_ARMV7M Stefan Agner
2015-05-09 20:39 ` [PATCH v6 10/12] ARM: vf610: enable Cortex-M4 configuration on Vybrid SoC Stefan Agner
2015-05-09 20:39 ` [PATCH v6 11/12] ARM: dts: add support for Vybrid running on Cortex-M4 Stefan Agner
2015-05-09 20:39 ` [PATCH v6 12/12] ARM: vf610m4: add defconfig for Linux on Vybrids Cortex-M4 Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af49d55159182668c21480e0fbaa85c@agner.ch \
--to=stefan@agner.ch \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®