mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	shli@fb.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nullb: make config_item_type const
Date: Thu, 12 Oct 2017 08:47:43 -0600	[thread overview]
Message-ID: <6b3e0504-99f6-ee3f-d3da-2858d9a5ca04@kernel.dk> (raw)
In-Reply-To: <CAOH+1jG=S6_Y+4haWBo09KDziVLjpMXkh-P46AK+7hR9-8e71g@mail.gmail.com>

On 10/12/2017 08:42 AM, Bhumika Goyal wrote:
> On Thu, Oct 12, 2017 at 4:27 PM, Jens Axboe <axboe@kernel.dk> wrote:
>> On 10/12/2017 04:19 AM, Bhumika Goyal wrote:
>>> This is a followup patch for: https://lkml.org/lkml/2017/10/11/375 and
>>> https://patchwork.kernel.org/patch/9999649/
>>>
>>> Make these structures const as they are either passed to the functions
>>> having the argument as const or stored as a reference in the "ci_type"
>>> const field of a config_item structure.
>>
>> Thanks, applied.
>>
> 
> Hello,
> 
> Actually, this patch is dependent on the patches in the links
> https://lkml.org/lkml/2017/10/11/375 and
> https://patchwork.kernel.org/patch/9999649/. Therefore, this patch
> won't be correct unless the patches in these links gets applied.

Gah, I do see that now. That should have been made much clearer in
the patch description!

When you send out patches with hard dependencies like that, either
wait until the dependency has been solved in mainline, or make it
explicitly clear in the patch submission.

-- 
Jens Axboe

  reply	other threads:[~2017-10-12 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 10:19 Bhumika Goyal
2017-10-12 14:27 ` Jens Axboe
2017-10-12 14:42   ` Bhumika Goyal
2017-10-12 14:47     ` Jens Axboe [this message]
2017-10-12 14:50       ` Bhumika Goyal
2017-10-14 23:19 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b3e0504-99f6-ee3f-d3da-2858d9a5ca04@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome