mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vignesh Viswanathan <quic_viswanat@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
	<andersson@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <ohad@wizery.com>,
	<baolin.wang@linux.alibaba.com>,
	<linux-remoteproc@vger.kernel.org>
Cc: <quic_kathirav@quicinc.com>, <quic_anusha@quicinc.com>,
	<quic_sjaganat@quicinc.com>, <quic_srichara@quicinc.com>,
	<quic_varada@quicinc.com>
Subject: Re: [PATCH 0/3] Fix tcsr_mutex register for IPQ6018
Date: Mon, 4 Sep 2023 22:57:31 +0530	[thread overview]
Message-ID: <6ba49071-c97a-4657-af67-0abf93cfa0d7@quicinc.com> (raw)
In-Reply-To: <9492bc16-2d8f-44a1-b2d6-d5f8353f30fa@linaro.org>



On 9/4/2023 9:28 PM, Konrad Dybcio wrote:
> On 4.09.2023 07:50, Vignesh Viswanathan wrote:
>> IPQ6018 has 32 tcsr_mutext hwlock registers of 0x1000 size each.
>> The compatible string qcom,ipq6018-tcsr-mutex is mapped to
>> of_msm8226_tcsr_mutex which has 32 locks configured with stride of 0x80
>> and doesn't match the HW present in IPQ6018.
>>
>> This series fixes the following:
>> 1. Fix the tcsr_mutex hwlock register size to 0x20000 in ipq6018.dtsi.
>> 2. Remove qcom,ipq6018-tcsr-mutex compatible string for tcsr_mutex in
>> ipq6018.dtsi.
>> 3. Drop unused qcom,ipq6018-tcsr-mutex compatible string from
>> qcom_hwspinlock driver and dt-bindings.
>>
> Sounds like 20230904063344.4144086-1-quic_viswanat@quicinc.com can't
> go in without this then?
> 

They can independently go in as the current max size and stride set for
IPQ6018 still has 32 locks and moving the index 3 shouldn't cause any 
issues.

However, functionally IPQ6018's HW lock is broken and will be fixed once 
this series goes in.

Thanks,
Vignesh
> Konrad

      reply	other threads:[~2023-09-04 17:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  5:50 Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 1/3] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size Vignesh Viswanathan
2023-09-04  6:40   ` Krzysztof Kozlowski
2023-09-04  6:57     ` Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 2/3] hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex Vignesh Viswanathan
2023-09-04  6:42   ` Krzysztof Kozlowski
2023-09-04 16:01     ` Konrad Dybcio
2023-09-04 16:09       ` Vignesh Viswanathan
2023-09-04 18:16         ` Krzysztof Kozlowski
2023-09-05  9:56           ` Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 3/3] dt-bindings: hwlock: " Vignesh Viswanathan
2023-09-04  6:42   ` Krzysztof Kozlowski
2023-09-04 15:58 ` [PATCH 0/3] Fix tcsr_mutex register for IPQ6018 Konrad Dybcio
2023-09-04 17:27   ` Vignesh Viswanathan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ba49071-c97a-4657-af67-0abf93cfa0d7@quicinc.com \
    --to=quic_viswanat@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=quic_anusha@quicinc.com \
    --cc=quic_kathirav@quicinc.com \
    --cc=quic_sjaganat@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®