mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Vignesh Viswanathan <quic_viswanat@quicinc.com>,
	agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, ohad@wizery.com,
	baolin.wang@linux.alibaba.com, linux-remoteproc@vger.kernel.org
Cc: quic_kathirav@quicinc.com, quic_anusha@quicinc.com,
	quic_sjaganat@quicinc.com, quic_srichara@quicinc.com,
	quic_varada@quicinc.com
Subject: Re: [PATCH 2/3] hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex
Date: Mon, 4 Sep 2023 18:01:20 +0200	[thread overview]
Message-ID: <880706cd-0987-47c7-8785-f8e4cb1c1907@linaro.org> (raw)
In-Reply-To: <17c8ba39-2bcf-5799-13ff-bb96249dbf61@linaro.org>

On 4.09.2023 08:42, Krzysztof Kozlowski wrote:
> On 04/09/2023 07:50, Vignesh Viswanathan wrote:
>> qcom,ipq6018-tcsr-mutex maps to incorrect config of IPQ6018 and is
>> dropped from the devictree. 
> 
> No, it is not dropped.
> 
> 
>> IPQ6018 will use qcom,tcsr-mutex compatible
>> string.
> 
> No, it will not.
> 
>>
>> Drop qcom,ipq6018-tcsr-mutex compatible string from
>> qcom_hwspinlock_of_match table.
> 
> Why? Do not write what you are doing here, but why you are doing it.
More importantly, looks like the ipq6018 compatible was added after
support for this SoC was introduced (see f5e303aefc06 and 5bf635621245a),
so if it's going to use of_tcsr_mutex data with the fallback compat, the
SoC-specific compatible can be removed from the driver.

Konrad

  reply	other threads:[~2023-09-04 16:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04  5:50 [PATCH 0/3] Fix tcsr_mutex register for IPQ6018 Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 1/3] arm64: dts: qcom: ipq6018: Fix tcsr_mutex register size Vignesh Viswanathan
2023-09-04  6:40   ` Krzysztof Kozlowski
2023-09-04  6:57     ` Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 2/3] hwspinlock: qcom: Drop unused qcom,ipq6018-tcsr-mutex Vignesh Viswanathan
2023-09-04  6:42   ` Krzysztof Kozlowski
2023-09-04 16:01     ` Konrad Dybcio [this message]
2023-09-04 16:09       ` Vignesh Viswanathan
2023-09-04 18:16         ` Krzysztof Kozlowski
2023-09-05  9:56           ` Vignesh Viswanathan
2023-09-04  5:50 ` [PATCH 3/3] dt-bindings: hwlock: " Vignesh Viswanathan
2023-09-04  6:42   ` Krzysztof Kozlowski
2023-09-04 15:58 ` [PATCH 0/3] Fix tcsr_mutex register for IPQ6018 Konrad Dybcio
2023-09-04 17:27   ` Vignesh Viswanathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=880706cd-0987-47c7-8785-f8e4cb1c1907@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=quic_anusha@quicinc.com \
    --cc=quic_kathirav@quicinc.com \
    --cc=quic_sjaganat@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=quic_viswanat@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®