From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Brian Gerst" <brgerst@gmail.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Cc: "Ingo Molnar" <mingo@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Borislav Petkov" <bp@alien8.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>, "Pavel Machek" <pavel@kernel.org>
Subject: Re: [PATCH v2 0/4] x86 suspend cleanups
Date: Wed, 04 Feb 2026 10:47:30 +0100 [thread overview]
Message-ID: <6bcfd942-79ce-40d5-b3bc-0690efd06d0d@app.fastmail.com> (raw)
In-Reply-To: <20260203175821.511847-1-brgerst@gmail.com>
On Tue, 3 Feb 2026, at 18:58, Brian Gerst wrote:
> This patchset cleans up the do_suspend_lowlevel() function, removing
> some leftover bits that are no longer necessary since it started
> using the SMP trampoline to resune the kernel.
>
> v2:
> - Reworked the first patch
> - Added more cleanups
>
> Brian Gerst (4):
> x86/acpi/suspend: Remove indirect jump
> x86/acpi/suspend: Remove segment reloads on resume
> x86/acpi/suspend: Clean up stack usage
> x86/acpi/suspend: Remove redundant register saves
>
This all looks correct to me - the stack changes in patch #3 do result in the stack misalignment to be different than it was before, but it is still 8 byte aligned throughout, which is all we care about in the kernel IIRC?
So
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Tested-by: Ard Biesheuvel <ardb@kernel.org> # qemu SMP suspend/resume
next prev parent reply other threads:[~2026-02-04 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:58 Brian Gerst
2026-02-03 17:58 ` [PATCH v2 1/4] x86/acpi/suspend: Remove indirect jump Brian Gerst
2026-02-03 17:58 ` [PATCH v2 2/4] x86/acpi/suspend: Remove segment reloads on resume Brian Gerst
2026-02-03 17:58 ` [PATCH v2 3/4] x86/acpi/suspend: Clean up stack usage Brian Gerst
2026-02-03 17:58 ` [PATCH v2 4/4] x86/acpi/suspend: Remove redundant register saves Brian Gerst
2026-02-03 20:31 ` [PATCH v2 0/4] x86 suspend cleanups Rafael J. Wysocki
2026-02-04 9:47 ` Ard Biesheuvel [this message]
2026-02-07 18:04 ` Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bcfd942-79ce-40d5-b3bc-0690efd06d0d@app.fastmail.com \
--to=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®