From: "David Müller (ELSOFT AG)" <d.mueller@elsoft.ch>
To: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>,
joel@jms.id.au, jdelvare@suse.com, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, corbet@lwn.net,
linux-doc@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [PATCH linux v4 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver
Date: Thu, 16 Mar 2017 09:05:31 +0100 [thread overview]
Message-ID: <6c028b76-ccc3-46ba-7a41-fa1b7b4a5b77@elsoft.ch> (raw)
In-Reply-To: <20170311015351.23092-2-jaghu@google.com>
Hello
Jaghathiswari Rankappagounder Natarajan wrote:
> +- compatible : should be "aspeed,aspeed2400-pwm-tacho" for AST2400
> or + "aspeed,aspeed2500-pwm-tacho" for AST2500.
Shouldn't this be "aspeed,ast2400-pwm-tacho" and
"aspeed,ast2500-pwm-tacho", as this is the naming scheme used for all
the other AST2x00 devices currently present in "aspeed-g[45].dtsi"?
Dave
next prev parent reply other threads:[~2017-03-16 8:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 1:53 [PATCH linux v4 0/2] Support for ASPEED AST2400/AST2500 PWM and Fan Tach driver Jaghathiswari Rankappagounder Natarajan
2017-03-11 1:53 ` [PATCH linux v4 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver Jaghathiswari Rankappagounder Natarajan
2017-03-16 8:05 ` David Müller (ELSOFT AG) [this message]
2017-03-20 16:15 ` Rob Herring
2017-03-11 1:53 ` [PATCH linux v4 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach Jaghathiswari Rankappagounder Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c028b76-ccc3-46ba-7a41-fa1b7b4a5b77@elsoft.ch \
--to=d.mueller@elsoft.ch \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jaghu@google.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®