From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
jishnu.prakash@oss.qualcomm.com
Cc: Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property
Date: Thu, 21 May 2026 10:46:15 +0200 [thread overview]
Message-ID: <6c595a5f-b979-4e8b-ae77-d28d24700588@oss.qualcomm.com> (raw)
In-Reply-To: <86f76a81-832d-4ba5-81d5-38b46b7dc0a7@kernel.org>
On 5/21/26 9:20 AM, Krzysztof Kozlowski wrote:
> On 21/05/2026 09:13, Kamal Wadhwa wrote:
>> On Tue, May 19, 2026 at 12:35:13PM +0200, Krzysztof Kozlowski wrote:
>>> On Tue, May 19, 2026 at 01:55:26PM +0530, Rakesh Kota wrote:
>>>>
>>>>> And isn't lack of monitored battery property enough to indicate that?
>>>>
>>>> Regarding monitored-battery — its absence alone isn't sufficient. The
>>>> BATT_ID line on debug boards is pulled to ~10kΩ, which is used during
>>>> development phase where some battery properties are still present. The
>>>> same ~10kΩ value is also used on some genuinely battery-less production
>>>> platforms where no battery properties exist, making auto-detection
>>>> unreliable. Hence the need for an explicit DT property to identify
>>>> hardware platforms where no battery populated.
>>>
>>> I don't understand this logic. So you claim you have debug boards which
>>> do not have battery, but define monitored-battery? Then these are wrong
>>> and fix them first.
>>
>> Actually our firmware treats the debug board as a "fake battery" rather then
>> a "no-battery" case.
>>
>> This is done to avoid triggering shutdown or trigger power/thermal related
>> mitigations to kick in from the HLOS (android) that is configured mainly for
>> battery-backed devices.
>>
>> Note that we can know if its a debug board, just by looking at the battery
>> ID resistance or the battery profile name in the power supply properties
>> for `qcom-battmgr-bat` in sysfs.
>>
>> However, the problem started with the boards that are battery-less and
>> unfortunetely used the same debug board batt ID resistance value, so from
>> the firmware side the batteryless board is also seen same as a board with
>> debug-board connected.
Bumping up my other reply, are there other markers that could interpreted,
perhaps design_capacity = 0?
Or are those values reported based on hardcoded data which is chosen
through the batt_id values you mentioned?
>> Since firmware does not have a way to dynamically tell if it on a
>> debug-board powered device or a DCIN powered device, We are required to
>> add this new DT property.
>
> Neither debug-board powered device nor battery-less will have
> monitored-battery, thus again, why lack of that property cannot tell you
> what you need?
A device with a battery will not have a monitored-battery either
Konrad
next prev parent reply other threads:[~2026-05-21 8:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 13:49 [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Rakesh Kota
2026-05-18 13:49 ` [PATCH 1/2] dt-bindings: soc: qcom: pmic-glink: Document batteryless property Rakesh Kota
2026-05-18 15:27 ` Krzysztof Kozlowski
2026-05-19 8:25 ` Rakesh Kota
2026-05-19 10:35 ` Krzysztof Kozlowski
2026-05-19 10:47 ` Konrad Dybcio
2026-05-19 10:49 ` Krzysztof Kozlowski
2026-05-21 7:13 ` Kamal Wadhwa
2026-05-21 7:20 ` Krzysztof Kozlowski
2026-05-21 8:46 ` Konrad Dybcio [this message]
2026-05-21 9:58 ` Krzysztof Kozlowski
2026-05-22 9:24 ` Konrad Dybcio
2026-05-22 10:32 ` Krzysztof Kozlowski
2026-05-22 10:34 ` Konrad Dybcio
2026-05-25 12:01 ` Rakesh Kota
2026-07-02 11:30 ` Rakesh Kota
2026-07-02 11:48 ` Krzysztof Kozlowski
2026-07-02 11:49 ` Dmitry Baryshkov
2026-07-17 0:14 ` Bjorn Andersson
2026-05-21 12:38 ` Rakesh Kota
2026-05-21 23:34 ` Dmitry Baryshkov
2026-05-18 13:49 ` [PATCH 2/2] power: supply: qcom_battmgr: Add support batteryless boards as MAINS Rakesh Kota
2026-07-17 0:12 ` Bjorn Andersson
2026-05-18 14:36 ` [PATCH 0/2] qcom_battmgr: Add batteryless DC-adapter MAINS support Konrad Dybcio
2026-05-19 6:59 ` Rakesh Kota
2026-05-19 10:58 ` Konrad Dybcio
2026-05-21 12:28 ` Rakesh Kota
2026-05-21 22:56 ` Bjorn Andersson
2026-06-30 14:16 ` Konrad Dybcio
2026-07-02 11:17 ` Rakesh Kota
2026-07-02 11:28 ` Krzysztof Kozlowski
2026-07-03 9:13 ` Rakesh Kota
2026-07-03 9:16 ` Krzysztof Kozlowski
2026-07-16 8:48 ` Rakesh Kota
2026-07-16 23:54 ` Bjorn Andersson
2026-07-17 10:00 ` Rakesh Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c595a5f-b979-4e8b-ae77-d28d24700588@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=kamal.wadhwa@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox