From: Chao Yu <yuchao0@huawei.com>
To: Daeho Jeong <daehojeong@google.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
<linux-f2fs-devel@lists.sourceforge.net>,
<kernel-janitors@vger.kernel.org>,
Colin Ian King <colin.king@canonical.com>,
<kernel-team@android.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks
Date: Wed, 6 Jan 2021 09:03:08 +0800 [thread overview]
Message-ID: <6c8e6561-8a5d-010f-3d7c-8c051b4027e6@huawei.com> (raw)
In-Reply-To: <dba4be04-70dd-d48b-391c-1f2355591097@web.de>
Daeho,
FYI
https://www.spinics.net/lists/kernel/msg3595944.html
On 2021/1/5 20:04, Markus Elfring wrote:
>> Fixed null page reference when find_lock_page() fails in
>> redirty_blocks().
>
> I suggest to choose an other imperative wording for this change description.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89
>
>
>> v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if branch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> .
>
next prev parent reply other threads:[~2021-01-06 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 4:16 Daeho Jeong
2021-01-05 6:05 ` [f2fs-dev] " Chao Yu
2021-01-05 9:34 ` Colin Ian King
[not found] ` <dba4be04-70dd-d48b-391c-1f2355591097@web.de>
2021-01-05 23:44 ` [f2fs-dev] " Daeho Jeong
2021-01-06 1:03 ` Chao Yu [this message]
2021-01-06 3:35 ` Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8e6561-8a5d-010f-3d7c-8c051b4027e6@huawei.com \
--to=yuchao0@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=colin.king@canonical.com \
--cc=daehojeong@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®