From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
<linux-modules@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v5 08/10] livepatch: Improve the search performance of module_kallsyms_on_each_symbol()
Date: Sat, 24 Sep 2022 20:10:57 +0800 [thread overview]
Message-ID: <6cddc5ab-6af5-c221-9383-a45d955af52b@huawei.com> (raw)
In-Reply-To: <4ef46874-4dbc-2663-ebad-7adbbbfa3b18@huawei.com>
On 2022/9/24 9:11, Leizhen (ThunderTown) wrote:
>
> On 2022/9/23 19:20, Zhen Lei wrote:
>> Currently we traverse all symbols of all modules to find the specified
>> function for the specified module. But in reality, we just need to find
>> the given module and then traverse all the symbols in it.
>>
>> In order to achieve this purpose, split the call to hook 'fn' into two
>> phases:
>> 1. Finds the given module. Pass pointer 'mod'. Hook 'fn' directly returns
>> the comparison result of the module name without comparing the function
>> name.
>> 2. Finds the given function in that module. Pass pointer 'mod = NULL'.
>> Hook 'fn' skip the comparison of module name and directly compare
>> function names.
> Sorry, I forgot to change the description. I will fix it in v6, after I've
> collected review comments.
Oh, It's Saturday, and I don't think anyone's seen v5 yet. So I'll post the v6.
Please skip v5.
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2022-09-24 12:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 11:20 [PATCH v5 00/10] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-09-23 11:20 ` [PATCH v5 01/10] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-09-23 11:20 ` [PATCH v5 02/10] scripts/kallsyms: don't compress symbol types Zhen Lei
2022-09-23 11:20 ` [PATCH v5 03/10] scripts/kallsyms: remove helper sym_name() and cleanup Zhen Lei
2022-09-23 11:20 ` [PATCH v5 04/10] scripts/kallsyms: generate kallsyms_best_token_table[] Zhen Lei
2022-09-23 11:20 ` [PATCH v5 05/10] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-09-23 11:20 ` [PATCH v5 06/10] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-09-23 11:20 ` [PATCH v5 07/10] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-09-23 11:20 ` [PATCH v5 08/10] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-09-24 1:11 ` Leizhen (ThunderTown)
2022-09-24 12:10 ` Leizhen (ThunderTown) [this message]
2022-09-23 11:20 ` [PATCH v5 09/10] kallsyms: Delete an unused parameter related to kallsyms_on_each_symbol() Zhen Lei
2022-09-23 11:20 ` [PATCH v5 10/10] kallsyms: Add self-test facility Zhen Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cddc5ab-6af5-c221-9383-a45d955af52b@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®