From: Finn Thain <fthain@telegraphics.com.au>
To: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Michael Schmitz" <schmitzmic@gmail.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH v2 1/7] Revert "scsi: ncr5380: Increase register polling limit"
Date: Sun, 09 Jun 2019 11:19:11 +1000 [thread overview]
Message-ID: <6cf0ec0a917ddfcf39ea8c697c8d8f7d663e9db3.1560043151.git.fthain@telegraphics.com.au> (raw)
In-Reply-To: <cover.1560043151.git.fthain@telegraphics.com.au>
This reverts commit 4822827a69d7cd3bc5a07b7637484ebd2cf88db6.
The purpose of that commit was to suppress a timeout warning message
which appeared to be caused by target latency. But suppressing the warning
is undesirable as the warning may indicate a messed up transfer count.
Another problem with that commit is that 15 ms is too long to keep
interrupts disabled as interrupt latency can cause system clock drift
and other problems.
Cc: Michael Schmitz <schmitzmic@gmail.com>
Cc: stable@vger.kernel.org
Fixes: 4822827a69d7 ("scsi: ncr5380: Increase register polling limit")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/scsi/NCR5380.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/NCR5380.h b/drivers/scsi/NCR5380.h
index efca509b92b0..5935fd6d1a05 100644
--- a/drivers/scsi/NCR5380.h
+++ b/drivers/scsi/NCR5380.h
@@ -235,7 +235,7 @@ struct NCR5380_cmd {
#define NCR5380_PIO_CHUNK_SIZE 256
/* Time limit (ms) to poll registers when IRQs are disabled, e.g. during PDMA */
-#define NCR5380_REG_POLL_TIME 15
+#define NCR5380_REG_POLL_TIME 10
static inline struct scsi_cmnd *NCR5380_to_scmd(struct NCR5380_cmd *ncmd_ptr)
{
--
2.21.0
next prev parent reply other threads:[~2019-06-09 1:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 1:19 [PATCH v2 0/7] NCR5380 drivers: fixes and other improvements Finn Thain
2019-06-09 1:19 ` [PATCH v2 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2 Finn Thain
2019-06-09 1:19 ` Finn Thain [this message]
2019-06-09 1:19 ` [PATCH v2 2/7] scsi: NCR5380: Always re-enable reselection interrupt Finn Thain
2019-06-11 5:07 ` Michael Schmitz
2019-06-11 9:33 ` Finn Thain
2019-06-11 23:46 ` Michael Schmitz
2019-06-19 0:47 ` Martin K. Petersen
2019-06-19 1:47 ` Michael Schmitz
2019-06-09 1:19 ` [PATCH v2 3/7] scsi: NCR5380: Handle PDMA failure reliably Finn Thain
2019-06-09 1:19 ` [PATCH v2 6/7] scsi: mac_scsi: Enable PDMA on Mac IIfx Finn Thain
2019-06-09 1:19 ` [PATCH v2 4/7] scsi: mac_scsi: Increase PIO/PDMA transfer length threshold Finn Thain
2019-06-09 1:19 ` [PATCH v2 7/7] scsi: mac_scsi: Treat Last Byte Sent time-out as failure Finn Thain
2019-06-19 2:40 ` [PATCH v2 0/7] NCR5380 drivers: fixes and other improvements Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cf0ec0a917ddfcf39ea8c697c8d8f7d663e9db3.1560043151.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®