From: Michael Schmitz <schmitzmic@gmail.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/7] scsi: NCR5380: Always re-enable reselection interrupt
Date: Wed, 12 Jun 2019 11:46:59 +1200 [thread overview]
Message-ID: <9c61076b-81f7-dc7b-0103-1e2e56072453@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.21.1906111926330.25@nippy.intranet>
Hi Finn,
On 11/06/19 9:33 PM, Finn Thain wrote:
> On Tue, 11 Jun 2019, Michael Schmitz wrote:
>
>> Hi Finn,
>>
>> IIRC I'd tested that change as well - didn't change broken target
>> behaviour but no regressions in other respects. Add my tested-by if
>> needed.
>>
> Unfortunately I can't confirm that this is the same patch as the one you
> tested as I no longer have that commit. But Stan did test a wide variety
> of targets and I'm confident that the reselection code path was covered.
>
No matter - patch applied cleanly to what I'm running on my Falcon, and
works just fine for now (stresstest will take a few hours to complete).
And that'll thoroughly exercise the reselection code path, from what
we've seen before.
Cheers,
Michael
next prev parent reply other threads:[~2019-06-11 23:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 1:19 [PATCH v2 0/7] NCR5380 drivers: fixes and other improvements Finn Thain
2019-06-09 1:19 ` [PATCH v2 1/7] Revert "scsi: ncr5380: Increase register polling limit" Finn Thain
2019-06-09 1:19 ` [PATCH v2 2/7] scsi: NCR5380: Always re-enable reselection interrupt Finn Thain
2019-06-11 5:07 ` Michael Schmitz
2019-06-11 9:33 ` Finn Thain
2019-06-11 23:46 ` Michael Schmitz [this message]
2019-06-19 0:47 ` Martin K. Petersen
2019-06-19 1:47 ` Michael Schmitz
2019-06-09 1:19 ` [PATCH v2 5/7] scsi: mac_scsi: Fix pseudo DMA implementation, take 2 Finn Thain
2019-06-09 1:19 ` [PATCH v2 3/7] scsi: NCR5380: Handle PDMA failure reliably Finn Thain
2019-06-09 1:19 ` [PATCH v2 4/7] scsi: mac_scsi: Increase PIO/PDMA transfer length threshold Finn Thain
2019-06-09 1:19 ` [PATCH v2 6/7] scsi: mac_scsi: Enable PDMA on Mac IIfx Finn Thain
2019-06-09 1:19 ` [PATCH v2 7/7] scsi: mac_scsi: Treat Last Byte Sent time-out as failure Finn Thain
2019-06-19 2:40 ` [PATCH v2 0/7] NCR5380 drivers: fixes and other improvements Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c61076b-81f7-dc7b-0103-1e2e56072453@gmail.com \
--to=schmitzmic@gmail.com \
--cc=fthain@telegraphics.com.au \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®