From: Andrew Lunn <andrew@lunn.ch>
To: "Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>, Andrew Davis <afd@ti.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] net: phy: dp83822: Add support for line class driver configuration
Date: Mon, 10 Jul 2023 21:38:51 +0200 [thread overview]
Message-ID: <6cf76d72-4747-46d2-a1f7-d2f1131491f7@lunn.ch> (raw)
In-Reply-To: <87fac0dd-9a97-b188-4887-8c4bb21196d5@vaisala.com>
> Hi Andrew,
>
> This is needed for configuration in link between DP83822 and Ethernet Switch
> chip.
What switch chip is it?
Most boards just connect the MACs together and don't have PHYs in the
middle. There are some boards which do have PHYs, but they don't need
any special mode.
> In the connection there there is no Ethernet cable at all but routes
> within the circuit boards but instead has capacitive coupling on routes.
So you also left out the magnetics?
> So the setting itself is related to specific circuit board design.
Agreed. So it is then valid to put it into DT, if it is actually
needed.
> MLT-3 is related to encoding used in the signals -- I suppose wiki page is
> good introduction reference:
>
> https://en.wikipedia.org/wiki/MLT-3_encoding
MLT-3 is well defined. What i could not find is any reference to what
reduced MLT-3 is. If it is not part of any standard, why don't you
just hard code the PHY to always use MTL-3 which is defined as part of
802.3?
I get the feeling reduced MLT-3 is TI proprietary. As such, it should
default to MLT-3 as defined in 802.3 and there could then be an option
to enable this proprietary mode for anybody we wants to use it.
So before accepting any patches, we need a better understanding of
that reduced MLT-3 is and why you would want to use it.
Andrew
next prev parent reply other threads:[~2023-07-10 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:56 Vesa Jääskeläinen
2023-07-10 17:56 ` [PATCH 1/2] dt-bindings: net: dp83822: Add line driver class selection Vesa Jääskeläinen
2023-07-10 17:56 ` [PATCH 2/2] net: phy: dp83822: Add support for line class driver configuration Vesa Jääskeläinen
2023-07-10 18:38 ` [PATCH 0/2] " Andrew Lunn
2023-07-10 19:08 ` Vesa Jääskeläinen
2023-07-10 19:38 ` Andrew Lunn [this message]
2023-07-11 7:51 ` Vesa Jääskeläinen
2023-07-11 15:35 ` Andrew Lunn
2023-07-11 16:05 ` Vesa Jääskeläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cf76d72-4747-46d2-a1f7-d2f1131491f7@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=vesa.jaaskelainen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®