From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Christophe Leroy <chleroy@kernel.org>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
linux-kernel@vger.kernel.org, Marco Elver <elver@google.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCHv2 14/18] powerpc/pseries: Annotate the DTL debugfs read lock context
Date: Thu, 19 Nov 2026 09:09:09 +0530 [thread overview]
Message-ID: <6d09c4ca6a515ca5daab5e45695e63de0040ceee.1795058683.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1795058683.git.ritesh.list@gmail.com>
Clang's context analysis reports:
dtl.c: error: rw_semaphore 'dtl_access_lock' is still held at the end of function [-Werror,-Wthread-safety-analysis]
dtl.c: error: releasing rw_semaphore 'dtl_access_lock' that was not held [-Werror,-Wthread-safety-analysis]
Add the necessary annotations to
dtl_{enable|disable}(), dtl_file{open|release}(),
to fix these errors for enabling Clang context analysis.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/platforms/pseries/dtl.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/pseries/dtl.c
index f293588b8c7b..18c597210103 100644
--- a/arch/powerpc/platforms/pseries/dtl.c
+++ b/arch/powerpc/platforms/pseries/dtl.c
@@ -177,7 +177,12 @@ static u64 dtl_current_index(struct dtl *dtl)
}
#endif /* CONFIG_VIRT_CPU_ACCOUNTING_NATIVE */
+/*
+ * On success the read lock stays held until dtl_disable(). That covers
+ * the whole time the debugfs file is open.
+ */
static int dtl_enable(struct dtl *dtl)
+ __cond_acquires_shared(0, &dtl_access_lock)
{
long int n_entries;
long int rc;
@@ -225,6 +230,7 @@ static int dtl_enable(struct dtl *dtl)
}
static void dtl_disable(struct dtl *dtl)
+ __releases_shared(&dtl_access_lock)
{
spin_lock(&dtl->lock);
dtl_stop(dtl);
@@ -238,6 +244,7 @@ static void dtl_disable(struct dtl *dtl)
/* file interface */
static int dtl_file_open(struct inode *inode, struct file *filp)
+ __cond_acquires_shared(0, &dtl_access_lock)
{
struct dtl *dtl = inode->i_private;
int rc;
@@ -251,6 +258,7 @@ static int dtl_file_open(struct inode *inode, struct file *filp)
}
static int dtl_file_release(struct inode *inode, struct file *filp)
+ __releases_shared(&dtl_access_lock)
{
struct dtl *dtl = inode->i_private;
dtl_disable(dtl);
--
2.39.5
next prev parent reply other threads:[~2026-11-19 3:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:38 [PATCHv2 00/18] powerpc/mm, pseries, powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 01/18] powerpc/mm/book3s64: unlock RCU before returning from mm_iommu_is_devmem() Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 02/18] powerpc/mm/book3s64: Rework tlbie() to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 03/18] powerpc/mm/book3s64: Rework native_flush_hash_range() " Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 04/18] powerpc/mm/book3s64: Annotate the subpage-protection PTE lock Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 05/18] powerpc/mm: Rework nohash TLB broadcast locking Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 06/18] powerpc/mm: Enable context analysis Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 07/18] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 08/18] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 09/18] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 10/18] powerpc/pseries: Add context annotations for the DTL worker lock Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 11/18] powerpc/pseries: Annotate the VPD sequence lock context Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 12/18] powerpc/pseries: Annotate the RTAS indices " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 13/18] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-11-19 3:39 ` Ritesh Harjani (IBM) [this message]
2026-11-19 3:39 ` [PATCHv2 15/18] powerpc/pseries: Disable context analysis for the CMM hotplug notifier Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 16/18] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 17/18] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 18/18] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d09c4ca6a515ca5daab5e45695e63de0040ceee.1795058683.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®