From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Christophe Leroy <chleroy@kernel.org>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
linux-kernel@vger.kernel.org, Marco Elver <elver@google.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCHv2 05/18] powerpc/mm: Rework nohash TLB broadcast locking
Date: Thu, 19 Nov 2026 09:09:00 +0530 [thread overview]
Message-ID: <ce4051abf3e8256e67232880f5381ba2f420887b.1795058683.git.ritesh.list@gmail.com> (raw)
In-Reply-To: <cover.1795058683.git.ritesh.list@gmail.com>
Clang's context analysis reports:
mmu_context.c:141:2: error: releasing raw_spinlock 'context_lock' that was not held [-Werror,-Wthread-safety-analysis]
mmu_context.c:147:1: error: raw_spinlock 'context_lock' is not held on every path through here [-Werror,-Wthread-safety-analysis]
tlb.c:257:4: error: raw_spinlock 'tlbivax_lock' is not held on every path through here [-Werror,-Wthread-safety-analysis]
tlb.c:259:5: error: releasing raw_spinlock 'tlbivax_lock' that was not held [-Werror,-Wthread-safety-analysis]
This reworks the locking in __flush_tlb_page() a bit to satisfy clang
context analyzer requirement.
Also steal_context_smp() drops the context_lock, so it needs to be
annotated with __must_hold to inform the clang analyzer that this
function holds the context_lock.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
arch/powerpc/mm/nohash/mmu_context.c | 1 +
arch/powerpc/mm/nohash/tlb.c | 8 +++++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/mm/nohash/mmu_context.c b/arch/powerpc/mm/nohash/mmu_context.c
index 28a96a10c907..bdbe1f55f388 100644
--- a/arch/powerpc/mm/nohash/mmu_context.c
+++ b/arch/powerpc/mm/nohash/mmu_context.c
@@ -95,6 +95,7 @@ static DEFINE_RAW_SPINLOCK(context_lock);
* -- benh
*/
static unsigned int steal_context_smp(unsigned int id)
+ __must_hold(&context_lock)
{
struct mm_struct *mm;
unsigned int cpu, max, i;
diff --git a/arch/powerpc/mm/nohash/tlb.c b/arch/powerpc/mm/nohash/tlb.c
index 07a2db16c2b1..9297549aef41 100644
--- a/arch/powerpc/mm/nohash/tlb.c
+++ b/arch/powerpc/mm/nohash/tlb.c
@@ -252,11 +252,13 @@ void __flush_tlb_page(struct mm_struct *mm, unsigned long vmaddr,
/* If broadcast tlbivax is supported, use it */
if (mmu_has_feature(MMU_FTR_USE_TLBIVAX_BCAST)) {
int lock = mmu_has_feature(MMU_FTR_LOCK_BCAST_INVAL);
- if (lock)
+ if (lock) {
raw_spin_lock(&tlbivax_lock);
- _tlbivax_bcast(vmaddr, pid, tsize, ind);
- if (lock)
+ _tlbivax_bcast(vmaddr, pid, tsize, ind);
raw_spin_unlock(&tlbivax_lock);
+ } else {
+ _tlbivax_bcast(vmaddr, pid, tsize, ind);
+ }
goto bail;
} else {
struct tlb_flush_param p = {
--
2.39.5
next prev parent reply other threads:[~2026-11-19 3:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 3:38 [PATCHv2 00/18] powerpc/mm, pseries, powernv: Enable clang context analysis Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 01/18] powerpc/mm/book3s64: unlock RCU before returning from mm_iommu_is_devmem() Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 02/18] powerpc/mm/book3s64: Rework tlbie() to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 03/18] powerpc/mm/book3s64: Rework native_flush_hash_range() " Ritesh Harjani (IBM)
2026-11-19 3:38 ` [PATCHv2 04/18] powerpc/mm/book3s64: Annotate the subpage-protection PTE lock Ritesh Harjani (IBM)
2026-11-19 3:39 ` Ritesh Harjani (IBM) [this message]
2026-11-19 3:39 ` [PATCHv2 06/18] powerpc/mm: Enable context analysis Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 07/18] powerpc/pseries: Drop inline from hugepage invalidate Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 08/18] powerpc/pseries: Rework hugepage invalidate to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 09/18] powerpc/pseries: Rework hash flush " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 10/18] powerpc/pseries: Add context annotations for the DTL worker lock Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 11/18] powerpc/pseries: Annotate the VPD sequence lock context Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 12/18] powerpc/pseries: Annotate the RTAS indices " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 13/18] powerpc/pseries: Annotate the RTAS physical-attestation " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 14/18] powerpc/pseries: Annotate the DTL debugfs read " Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 15/18] powerpc/pseries: Disable context analysis for the CMM hotplug notifier Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 16/18] powerpc/pseries: Enable context analysis Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 17/18] powerpc/powernv: Rework OPAL console write to remove conditional locking Ritesh Harjani (IBM)
2026-11-19 3:39 ` [PATCHv2 18/18] powerpc/powernv: Enable context analysis Ritesh Harjani (IBM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4051abf3e8256e67232880f5381ba2f420887b.1795058683.git.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=chleroy@kernel.org \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®