From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Luca Weiss <luca@lucaweiss.eu>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
Date: Mon, 24 Feb 2025 21:27:19 +0100 [thread overview]
Message-ID: <6d1a95a1-0b84-4bc5-9cb0-3cc514d292a6@oss.qualcomm.com> (raw)
In-Reply-To: <w4l5drhu6exq4jb7x2pisqtkz5ylare7ashsmjjqomv3yetjwj@z3wapq4rkk3u>
On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote:
> On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
>> Set the paths where the device-specific firmware can be found for this
>> device.
>>
>> Fairphone 3 was shipped with secure-boot off so any testkey-signed
>> firmware is accepted.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>> arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> @@ -82,6 +82,8 @@ nfc@28 {
>> };
>>
>> &lpass {
>> + firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
>
> If any firmware is okay, wouldn't it be better to use
> "qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
> I'm a dreamer), then FB3 can pick it up.
No, the fw may have board/wiring differences encoded inside it
Konrad
next prev parent reply other threads:[~2025-02-24 20:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
2025-02-24 0:19 ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes Luca Weiss
2025-02-24 0:19 ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss Luca Weiss
2025-02-24 0:17 ` Dmitry Baryshkov
2025-02-24 20:27 ` Konrad Dybcio [this message]
2025-02-24 20:43 ` Luca Weiss
2025-02-25 3:17 ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem Luca Weiss
2025-02-24 0:18 ` Dmitry Baryshkov
2025-02-25 3:17 ` Dmitry Baryshkov
2025-03-04 17:00 ` [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d1a95a1-0b84-4bc5-9cb0-3cc514d292a6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaweiss.eu \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®