mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem
@ 2025-02-22 13:00 Luca Weiss
  2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Luca Weiss @ 2025-02-22 13:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss

The main objective is setting firmware-name for the remoteprocs and
enabling the modem.

The first two patches are just some cleanups to align the dts style with
contemporary style.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
Luca Weiss (4):
      arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last
      arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes
      arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
      arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem

 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 48 ++++++++++++++++++++---
 1 file changed, 42 insertions(+), 6 deletions(-)
---
base-commit: 245879bbd9af3559c3b0351ca0d93f324214c9d6
change-id: 20250222-fp3-remoteprocs-firmware-ba35854d82bf

Best regards,
-- 
Luca Weiss <luca@lucaweiss.eu>


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last
  2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
@ 2025-02-22 13:00 ` Luca Weiss
  2025-02-24  0:19   ` Dmitry Baryshkov
  2025-02-22 13:00 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes Luca Weiss
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Luca Weiss @ 2025-02-22 13:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss

As is common style nowadays, move the status properties to be the last
property of a node.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 2c1172aa97e4bd1f4e905e9777e26672e8935d2f..957288853da2b857af77d9f5fd4de94900ee9b5f 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -45,10 +45,11 @@ vph_pwr: vph-pwr-regulator {
 };
 
 &hsusb_phy {
-	status = "okay";
 	vdd-supply = <&pm8953_l3>;
 	vdda-pll-supply = <&pm8953_l7>;
 	vdda-phy-dpdm-supply = <&pm8953_l13>;
+
+	status = "okay";
 };
 
 &i2c_3 {
@@ -85,8 +86,8 @@ &lpass {
 };
 
 &pm8953_resin {
-	status = "okay";
 	linux,code = <KEY_VOLUMEDOWN>;
+	status = "okay";
 };
 
 &pmi632_lpg {
@@ -148,17 +149,19 @@ &pmi632_vib {
 };
 
 &sdhc_1 {
-	status = "okay";
 	vmmc-supply = <&pm8953_l8>;
 	vqmmc-supply = <&pm8953_l5>;
+
+	status = "okay";
 };
 
 &sdhc_2 {
-	status = "okay";
 	vmmc-supply = <&pm8953_l11>;
 	vqmmc-supply = <&pm8953_l12>;
 
 	cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+
+	status = "okay";
 };
 
 &rpm_requests {
@@ -276,9 +279,9 @@ &usb_dwc3_hs {
 };
 
 &wcnss {
-	status = "okay";
-
 	vddpx-supply = <&pm8953_l5>;
+
+	status = "okay";
 };
 
 &wcnss_iris {

-- 
2.48.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes
  2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
  2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
@ 2025-02-22 13:00 ` Luca Weiss
  2025-02-24  0:19   ` Dmitry Baryshkov
  2025-02-22 13:00 ` [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss Luca Weiss
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Luca Weiss @ 2025-02-22 13:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss

As is common style nowadays, make sure there's an empty line between
regulator subnodes.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 957288853da2b857af77d9f5fd4de94900ee9b5f..08ffe77d762c3a97f470efbfb5064282fe2090da 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -178,10 +178,12 @@ pm8953_s3: s3 {
 			regulator-min-microvolt = <984000>;
 			regulator-max-microvolt = <1240000>;
 		};
+
 		pm8953_s4: s4 {
 			regulator-min-microvolt = <1036000>;
 			regulator-max-microvolt = <2040000>;
 		};
+
 		pm8953_s5: s5 {
 			regulator-min-microvolt = <1036000>;
 			regulator-max-microvolt = <2040000>;
@@ -191,66 +193,82 @@ pm8953_l1: l1 {
 			regulator-min-microvolt = <975000>;
 			regulator-max-microvolt = <1050000>;
 		};
+
 		pm8953_l2: l2 {
 			regulator-min-microvolt = <975000>;
 			regulator-max-microvolt = <1175000>;
 		};
+
 		pm8953_l3: l3 {
 			regulator-min-microvolt = <925000>;
 			regulator-max-microvolt = <925000>;
 		};
+
 		pm8953_l5: l5 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 		};
+
 		pm8953_l6: l6 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 		};
+
 		pm8953_l7: l7 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1900000>;
 		};
+
 		pm8953_l8: l8 {
 			regulator-min-microvolt = <2900000>;
 			regulator-max-microvolt = <2900000>;
 		};
+
 		pm8953_l9: l9 {
 			regulator-min-microvolt = <3000000>;
 			regulator-max-microvolt = <3300000>;
 		};
+
 		pm8953_l10: l10 {
 			regulator-min-microvolt = <2800000>;
 			regulator-max-microvolt = <3000000>;
 		};
+
 		pm8953_l11: l11 {
 			regulator-min-microvolt = <2950000>;
 			regulator-max-microvolt = <2950000>;
 		};
+
 		pm8953_l12: l12 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <2950000>;
 		};
+
 		pm8953_l13: l13 {
 			regulator-min-microvolt = <3125000>;
 			regulator-max-microvolt = <3125000>;
 		};
+
 		pm8953_l16: l16 {
 			regulator-min-microvolt = <1800000>;
 			regulator-max-microvolt = <1800000>;
 		};
+
 		pm8953_l17: l17 {
 			regulator-min-microvolt = <2850000>;
 			regulator-max-microvolt = <2850000>;
 		};
+
 		pm8953_l19: l19 {
 			regulator-min-microvolt = <1200000>;
 			regulator-max-microvolt = <1350000>;
 		};
+
 		pm8953_l22: l22 {
 			regulator-min-microvolt = <2800000>;
 			regulator-max-microvolt = <2800000>;
 		};
+
 		pm8953_l23: l23 {
 			regulator-min-microvolt = <975000>;
 			regulator-max-microvolt = <1225000>;

-- 
2.48.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
  2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
  2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
  2025-02-22 13:00 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes Luca Weiss
@ 2025-02-22 13:00 ` Luca Weiss
  2025-02-24  0:17   ` Dmitry Baryshkov
  2025-02-22 13:00 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem Luca Weiss
  2025-03-04 17:00 ` [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Bjorn Andersson
  4 siblings, 1 reply; 14+ messages in thread
From: Luca Weiss @ 2025-02-22 13:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss

Set the paths where the device-specific firmware can be found for this
device.

Fairphone 3 was shipped with secure-boot off so any testkey-signed
firmware is accepted.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -82,6 +82,8 @@ nfc@28 {
 };
 
 &lpass {
+	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
+
 	status = "okay";
 };
 
@@ -297,11 +299,16 @@ &usb_dwc3_hs {
 };
 
 &wcnss {
+	firmware-name = "qcom/msm8953/fairphone/fp3/wcnss.mbn";
 	vddpx-supply = <&pm8953_l5>;
 
 	status = "okay";
 };
 
+&wcnss_ctrl {
+	firmware-name = "qcom/msm8953/fairphone/fp3/WCNSS_qcom_wlan_nv.bin";
+};
+
 &wcnss_iris {
 	compatible = "qcom,wcn3680";
 

-- 
2.48.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem
  2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
                   ` (2 preceding siblings ...)
  2025-02-22 13:00 ` [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss Luca Weiss
@ 2025-02-22 13:00 ` Luca Weiss
  2025-02-24  0:18   ` Dmitry Baryshkov
  2025-03-04 17:00 ` [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Bjorn Andersson
  4 siblings, 1 reply; 14+ messages in thread
From: Luca Weiss @ 2025-02-22 13:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Luca Weiss

Add the necessary supplies and set an appropriete firmware-name for the
modem and enable it.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 5611209dbfa41d7834af7903535ed3e05604ba63..31ed26c31e6ea381a8942ccf569513df3300cdeb 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -87,6 +87,14 @@ &lpass {
 	status = "okay";
 };
 
+&mpss {
+	firmware-name = "qcom/msm8953/fairphone/fp3/mba.mbn",
+			"qcom/msm8953/fairphone/fp3/modem.mbn";
+	pll-supply = <&pm8953_l7>;
+
+	status = "okay";
+};
+
 &pm8953_resin {
 	linux,code = <KEY_VOLUMEDOWN>;
 	status = "okay";

-- 
2.48.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
  2025-02-22 13:00 ` [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss Luca Weiss
@ 2025-02-24  0:17   ` Dmitry Baryshkov
  2025-02-24 20:27     ` Konrad Dybcio
  0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-24  0:17 UTC (permalink / raw)
  To: Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
> Set the paths where the device-specific firmware can be found for this
> device.
> 
> Fairphone 3 was shipped with secure-boot off so any testkey-signed
> firmware is accepted.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> @@ -82,6 +82,8 @@ nfc@28 {
>  };
>  
>  &lpass {
> +	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";

If any firmware is okay, wouldn't it be better to use
"qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
I'm a dreamer), then FB3 can pick it up.

> +
>  	status = "okay";
>  };
>  
> @@ -297,11 +299,16 @@ &usb_dwc3_hs {
>  };
>  
>  &wcnss {
> +	firmware-name = "qcom/msm8953/fairphone/fp3/wcnss.mbn";
>  	vddpx-supply = <&pm8953_l5>;
>  
>  	status = "okay";
>  };
>  
> +&wcnss_ctrl {
> +	firmware-name = "qcom/msm8953/fairphone/fp3/WCNSS_qcom_wlan_nv.bin";

then this can become "qcom/msm8953/WCNSS_qcom_wlan_nv_fp3.bin"

> +};
> +
>  &wcnss_iris {
>  	compatible = "qcom,wcn3680";
>  
> 
> -- 
> 2.48.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem
  2025-02-22 13:00 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem Luca Weiss
@ 2025-02-24  0:18   ` Dmitry Baryshkov
  2025-02-25  3:17     ` Dmitry Baryshkov
  0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-24  0:18 UTC (permalink / raw)
  To: Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On Sat, Feb 22, 2025 at 02:00:50PM +0100, Luca Weiss wrote:
> Add the necessary supplies and set an appropriete firmware-name for the

Nit: appropriate

> modem and enable it.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> index 5611209dbfa41d7834af7903535ed3e05604ba63..31ed26c31e6ea381a8942ccf569513df3300cdeb 100644
> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> @@ -87,6 +87,14 @@ &lpass {
>  	status = "okay";
>  };
>  
> +&mpss {
> +	firmware-name = "qcom/msm8953/fairphone/fp3/mba.mbn",
> +			"qcom/msm8953/fairphone/fp3/modem.mbn";

THe comment from the previous patch applies.

> +	pll-supply = <&pm8953_l7>;
> +
> +	status = "okay";
> +};
> +
>  &pm8953_resin {
>  	linux,code = <KEY_VOLUMEDOWN>;
>  	status = "okay";
> 
> -- 
> 2.48.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last
  2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
@ 2025-02-24  0:19   ` Dmitry Baryshkov
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-24  0:19 UTC (permalink / raw)
  To: Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On Sat, Feb 22, 2025 at 02:00:47PM +0100, Luca Weiss wrote:
> As is common style nowadays, move the status properties to be the last
> property of a node.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes
  2025-02-22 13:00 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes Luca Weiss
@ 2025-02-24  0:19   ` Dmitry Baryshkov
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-24  0:19 UTC (permalink / raw)
  To: Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On Sat, Feb 22, 2025 at 02:00:48PM +0100, Luca Weiss wrote:
> As is common style nowadays, make sure there's an empty line between
> regulator subnodes.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
  2025-02-24  0:17   ` Dmitry Baryshkov
@ 2025-02-24 20:27     ` Konrad Dybcio
  2025-02-24 20:43       ` Luca Weiss
  0 siblings, 1 reply; 14+ messages in thread
From: Konrad Dybcio @ 2025-02-24 20:27 UTC (permalink / raw)
  To: Dmitry Baryshkov, Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote:
> On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
>> Set the paths where the device-specific firmware can be found for this
>> device.
>>
>> Fairphone 3 was shipped with secure-boot off so any testkey-signed
>> firmware is accepted.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>> @@ -82,6 +82,8 @@ nfc@28 {
>>  };
>>  
>>  &lpass {
>> +	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
> 
> If any firmware is okay, wouldn't it be better to use
> "qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
> I'm a dreamer), then FB3 can pick it up.

No, the fw may have board/wiring differences encoded inside it

Konrad

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
  2025-02-24 20:27     ` Konrad Dybcio
@ 2025-02-24 20:43       ` Luca Weiss
  2025-02-25  3:17         ` Dmitry Baryshkov
  0 siblings, 1 reply; 14+ messages in thread
From: Luca Weiss @ 2025-02-24 20:43 UTC (permalink / raw)
  To: Konrad Dybcio, Dmitry Baryshkov
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On 24-02-2025 9:27 p.m., Konrad Dybcio wrote:
> On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote:
>> On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
>>> Set the paths where the device-specific firmware can be found for this
>>> device.
>>>
>>> Fairphone 3 was shipped with secure-boot off so any testkey-signed
>>> firmware is accepted.
>>>
>>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
>>> @@ -82,6 +82,8 @@ nfc@28 {
>>>   };
>>>   
>>>   &lpass {
>>> +	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
>>
>> If any firmware is okay, wouldn't it be better to use
>> "qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
>> I'm a dreamer), then FB3 can pick it up.
> 
> No, the fw may have board/wiring differences encoded inside it

Second that, while I don't have access to the AMSS sources for this 
device, I'm sure there's at least some board-specific config in these 
images, and I'd rather not boot up some ADSP or modem firmware compiled 
for some Dragonboard or equivalent.

Regards
Luca

> 
> Konrad


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
  2025-02-24 20:43       ` Luca Weiss
@ 2025-02-25  3:17         ` Dmitry Baryshkov
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-25  3:17 UTC (permalink / raw)
  To: Luca Weiss
  Cc: Konrad Dybcio, ~postmarketos/upstreaming, phone-devel,
	Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Mon, Feb 24, 2025 at 09:43:48PM +0100, Luca Weiss wrote:
> On 24-02-2025 9:27 p.m., Konrad Dybcio wrote:
> > On 24.02.2025 1:17 AM, Dmitry Baryshkov wrote:
> > > On Sat, Feb 22, 2025 at 02:00:49PM +0100, Luca Weiss wrote:
> > > > Set the paths where the device-specific firmware can be found for this
> > > > device.
> > > > 
> > > > Fairphone 3 was shipped with secure-boot off so any testkey-signed
> > > > firmware is accepted.
> > > > 
> > > > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > > > ---
> > > >   arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 7 +++++++
> > > >   1 file changed, 7 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > > > index 08ffe77d762c3a97f470efbfb5064282fe2090da..5611209dbfa41d7834af7903535ed3e05604ba63 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > > > @@ -82,6 +82,8 @@ nfc@28 {
> > > >   };
> > > >   &lpass {
> > > > +	firmware-name = "qcom/msm8953/fairphone/fp3/adsp.mbn";
> > > 
> > > If any firmware is okay, wouldn't it be better to use
> > > "qcom/msm8953/foo.mbn" ? This way if we get any of the firmware (yeah,
> > > I'm a dreamer), then FB3 can pick it up.
> > 
> > No, the fw may have board/wiring differences encoded inside it
> 
> Second that, while I don't have access to the AMSS sources for this device,
> I'm sure there's at least some board-specific config in these images, and
> I'd rather not boot up some ADSP or modem firmware compiled for some
> Dragonboard or equivalent.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem
  2025-02-24  0:18   ` Dmitry Baryshkov
@ 2025-02-25  3:17     ` Dmitry Baryshkov
  0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Baryshkov @ 2025-02-25  3:17 UTC (permalink / raw)
  To: Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, Bjorn Andersson,
	Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel

On Mon, Feb 24, 2025 at 02:18:55AM +0200, Dmitry Baryshkov wrote:
> On Sat, Feb 22, 2025 at 02:00:50PM +0100, Luca Weiss wrote:
> > Add the necessary supplies and set an appropriete firmware-name for the
> 
> Nit: appropriate
> 
> > modem and enable it.
> > 
> > Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > index 5611209dbfa41d7834af7903535ed3e05604ba63..31ed26c31e6ea381a8942ccf569513df3300cdeb 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
> > @@ -87,6 +87,14 @@ &lpass {
> >  	status = "okay";
> >  };
> >  
> > +&mpss {
> > +	firmware-name = "qcom/msm8953/fairphone/fp3/mba.mbn",
> > +			"qcom/msm8953/fairphone/fp3/modem.mbn";
> 
> THe comment from the previous patch applies.
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem
  2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
                   ` (3 preceding siblings ...)
  2025-02-22 13:00 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem Luca Weiss
@ 2025-03-04 17:00 ` Bjorn Andersson
  4 siblings, 0 replies; 14+ messages in thread
From: Bjorn Andersson @ 2025-03-04 17:00 UTC (permalink / raw)
  To: ~postmarketos/upstreaming, phone-devel, Konrad Dybcio,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Luca Weiss
  Cc: linux-arm-msm, devicetree, linux-kernel


On Sat, 22 Feb 2025 14:00:46 +0100, Luca Weiss wrote:
> The main objective is setting firmware-name for the remoteprocs and
> enabling the modem.
> 
> The first two patches are just some cleanups to align the dts style with
> contemporary style.
> 
> 
> [...]

Applied, thanks!

[1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last
      commit: 09a3840bcb72bcd9b43cbffbb7dedccf85e6d558
[2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes
      commit: a4600b160eca7f889c4b4a370d42e4619fa5162a
[3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss
      commit: 9ab813d5191f61301dbaeaf8e82d21e689b080f4
[4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem
      commit: d0c38cbe3556fea446b9350ec597a8e9c2cdaf36

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-03-04 17:00 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-22 13:00 [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Luca Weiss
2025-02-22 13:00 ` [PATCH 1/4] arm64: dts: qcom: sdm632-fairphone-fp3: Move status properties last Luca Weiss
2025-02-24  0:19   ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add newlines between regulator nodes Luca Weiss
2025-02-24  0:19   ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 3/4] arm64: dts: qcom: sdm632-fairphone-fp3: Add firmware-name for adsp & wcnss Luca Weiss
2025-02-24  0:17   ` Dmitry Baryshkov
2025-02-24 20:27     ` Konrad Dybcio
2025-02-24 20:43       ` Luca Weiss
2025-02-25  3:17         ` Dmitry Baryshkov
2025-02-22 13:00 ` [PATCH 4/4] arm64: dts: qcom: sdm632-fairphone-fp3: Enable modem Luca Weiss
2025-02-24  0:18   ` Dmitry Baryshkov
2025-02-25  3:17     ` Dmitry Baryshkov
2025-03-04 17:00 ` [PATCH 0/4] Some cleanups for Fairphone 3, set firmware-name, enable modem Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®