* [PATCH] kselftest: Fix error message for unconfigured LLVM builds
@ 2023-01-11 22:33 Mark Brown
2023-01-11 23:20 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2023-01-11 22:33 UTC (permalink / raw)
To: Shuah Khan, Nathan Chancellor, Nick Desaulniers, Tom Rix
Cc: linux-kselftest, linux-kernel, llvm, Mark Brown
We are missing a ) when we attempt to complain about not having enough
configuration for clang, resulting in the rather inscrutable error:
../lib.mk:23: *** unterminated call to function 'error': missing ')'. Stop.
Add the required ) so we print the message we were trying to print.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/lib.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 291144c284fb..f7900e75d230 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH))
ifeq ($(CROSS_COMPILE),)
ifeq ($(CLANG_TARGET_FLAGS),)
-$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
+$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
else
CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS)
endif # CLANG_TARGET_FLAGS
---
base-commit: b7bfaa761d760e72a969d116517eaa12e404c262
change-id: 20230111-kselftest-lib-clang-fix-8936ba376ea1
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kselftest: Fix error message for unconfigured LLVM builds
2023-01-11 22:33 [PATCH] kselftest: Fix error message for unconfigured LLVM builds Mark Brown
@ 2023-01-11 23:20 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2023-01-11 23:20 UTC (permalink / raw)
To: Mark Brown, Shuah Khan, Nathan Chancellor, Nick Desaulniers, Tom Rix
Cc: linux-kselftest, linux-kernel, llvm, Shuah Khan
On 1/11/23 15:33, Mark Brown wrote:
> We are missing a ) when we attempt to complain about not having enough
> configuration for clang, resulting in the rather inscrutable error:
>
> ../lib.mk:23: *** unterminated call to function 'error': missing ')'. Stop.
>
> Add the required ) so we print the message we were trying to print.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/lib.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 291144c284fb..f7900e75d230 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS := $(CLANG_TARGET_FLAGS_$(ARCH))
>
> ifeq ($(CROSS_COMPILE),)
> ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
> +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
> else
> CLANG_FLAGS += --target=$(CLANG_TARGET_FLAGS)
> endif # CLANG_TARGET_FLAGS
>
> ---
> base-commit: b7bfaa761d760e72a969d116517eaa12e404c262
> change-id: 20230111-kselftest-lib-clang-fix-8936ba376ea1
>
> Best regards,
Thank you. I will queue this up for the next rc.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-11 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-11 22:33 [PATCH] kselftest: Fix error message for unconfigured LLVM builds Mark Brown
2023-01-11 23:20 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®