From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: <t-kristo@ti.com>, <ssantosh@kernel.org>, <lokeshvutla@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode
Date: Fri, 9 Oct 2020 10:43:26 +0300 [thread overview]
Message-ID: <6d8f5331-251d-5409-4a1c-e3e42d340071@ti.com> (raw)
In-Reply-To: <20201009030204.3i3d6azsmfekl5qx@whole>
Nishanth,
On 09/10/2020 6.02, Nishanth Menon wrote:
> On 14:52-20201008, Peter Ujfalusi wrote:
>> - ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev,
>> + ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
>> ring->size * (4 << ring->elm_size),
>> &ring->ring_mem_dma, GFP_KERNEL);
>
> Any chance of getting a cleanup of the file for 5.11? I know this series
> has'nt introduced this warning or set of warnings, but I am starting to
> get concerned that we are carrying over too much of a debt now?
>
> https://pastebin.ubuntu.com/p/tT2kPDsCWD/
Right, you know that git blame points the finger at you on ti_sci.c errors?
Never the less, I have run the tool locally on my linux-next-wip with
these patches:
https://pastebin.ubuntu.com/p/myJwjvKYw8/
and I don't see the noise you see.
> Checkpatch does point this:
>
> --- /tmp/kernel-patch-verify.25812/ptest_check-start 2020-10-08
> 19:33:31.025898581 +0000
> +++ /tmp/kernel-patch-verify.25812/ptest_check-end 2020-10-08
> 19:33:31.593893830 +0000
> @@ -0,0 +1,6 @@
> +CHECK: Alignment should match open parenthesis
> +#84: FILE: drivers/soc/ti/k3-ringacc.c:657:
> ++ ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
> + ring->size * (4 << ring->elm_size),
Yes, that's correct. Readability VS very long lines
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-10-09 7:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 11:52 [PATCH v2 00/11] firmware/soc: ti_sci, ringacc/inta: Preparation for AM64 DMA support Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 01/11] firmware: ti_sci: rm: Add support for tx_tdtype parameter for tx channel Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 02/11] firmware: ti_sci: Use struct ti_sci_resource_desc in get_range ops Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 03/11] firmware: ti_sci: rm: Add support for second resource range Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 04/11] soc: ti: ti_sci_inta_msi: Add support for second range in resource ranges Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 05/11] firmware: ti_sci: rm: Add support for extended_ch_type for tx channel Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 06/11] firmware: ti_sci: rm: Remove ring_get_config support Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 07/11] firmware: ti_sci: rm: Add new ops for ring configuration Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 08/11] soc: ti: k3-ringacc: Use the ti_sci set_cfg callback " Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 09/11] firmware: ti_sci: rm: Remove unused config() from ti_sci_rm_ringacc_ops Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode Peter Ujfalusi
2020-10-09 3:02 ` Nishanth Menon
2020-10-09 7:43 ` Peter Ujfalusi [this message]
2020-10-09 11:59 ` Nishanth Menon
2020-10-09 12:10 ` Peter Ujfalusi
2020-10-08 11:52 ` [PATCH v2 11/11] soc: ti: k3-socinfo: Add entry for AM64X SoC family Peter Ujfalusi
2020-10-09 0:54 ` [PATCH v2 00/11] firmware/soc: ti_sci, ringacc/inta: Preparation for AM64 DMA support santosh.shilimkar
2020-10-09 0:56 ` santosh.shilimkar
2020-10-09 8:08 ` Peter Ujfalusi
2020-11-02 3:44 ` santosh.shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8f5331-251d-5409-4a1c-e3e42d340071@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®