mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Oros <poros@redhat.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: netdev@vger.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Eric Dumazet <edumazet@google.com>,
	Ahmed Zaki <ahmed.zaki@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	intel-wired-lan@lists.osuosl.org,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] iavf: fix VLAN filter lost on add/delete race
Date: Wed, 25 Feb 2026 15:57:16 +0100	[thread overview]
Message-ID: <6d93637e-cc59-45e5-9365-8140f53e4004@redhat.com> (raw)
In-Reply-To: <CADEbmW2WNCLuRYVs5FTKR6GR16yOMmQGyg0vYR98SQCCwb_5HA@mail.gmail.com>


On 2/25/26 12:17, Michal Schmidt wrote:
> On Wed, Feb 25, 2026 at 11:02 AM Petr Oros <poros@redhat.com> wrote:
>> When iavf_add_vlan() finds an existing filter in IAVF_VLAN_REMOVE
>> state, it transitions the filter to IAVF_VLAN_ACTIVE assuming the
>> pending delete can simply be cancelled. However, there is no guarantee
>> that iavf_del_vlans() has not already processed the delete AQ request
>> and removed the filter from the PF. In that case the filter remains in
>> the driver's list as IAVF_VLAN_ACTIVE but is no longer programmed on
>> the NIC. Since iavf_add_vlans() only picks up filters in
>> IAVF_VLAN_ADD state, the filter is never re-added, and spoof checking
>> drops all traffic for that VLAN.
>>
>>    CPU0                       CPU1                     Workqueue
>>    ----                       ----                     ---------
>>    iavf_del_vlan(vlan 100)
>>      f->state = REMOVE
>>      schedule AQ_DEL_VLAN
>>                               iavf_add_vlan(vlan 100)
>>                                 f->state = ACTIVE
>>                                                        iavf_del_vlans()
>>                                                          f is ACTIVE, skip
>>                                                        iavf_add_vlans()
>>                                                          f is ACTIVE, skip
>>
>>    Filter is ACTIVE in driver but absent from NIC.
> I don't get it. If, as the diagram shows, iavf_del_vlans() skipped it,
> then how does the filter become absent from NIC?

VLAN teardown            Workqueue           VLAN setup
-------------            ---------           ----------
iavf_del_vlan(100)
   f->state = REMOVE
   schedule AQ_DEL_VLAN
                                              iavf_open()
                                                restore_filters()
                                                  f is REMOVE, skip
                                                iavf_add_vlan(100)
                                                 f->state = ACTIVE

                          iavf_del_vlans()
                           f is ACTIVE, skip
                          iavf_add_vlans()
                           f is ACTIVE, skip

Is it clear like this?

> Michal
>
>> Transition to IAVF_VLAN_ADD instead and schedule
>> IAVF_FLAG_AQ_ADD_VLAN_FILTER so iavf_add_vlans() re-programs the
>> filter.  A duplicate add is idempotent on the PF.
>>
>> Fixes: 0c0da0e95105 ("iavf: refactor VLAN filter states")
>>
>> Signed-off-by: Petr Oros <poros@redhat.com>
>> ---
>>   drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ++++++---
>>   1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
>> index 4b0fc8f354bc90..6046b93c7f3472 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
>> @@ -782,10 +782,13 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter *adapter,
>>                  adapter->num_vlan_filters++;
>>                  iavf_schedule_aq_request(adapter, IAVF_FLAG_AQ_ADD_VLAN_FILTER);
>>          } else if (f->state == IAVF_VLAN_REMOVE) {
>> -               /* IAVF_VLAN_REMOVE means that VLAN wasn't yet removed.
>> -                * We can safely only change the state here.
>> +               /* Re-add the filter since we cannot tell whether the
>> +                * pending delete has already been processed by the PF.
>> +                * A duplicate add is harmless.
>>                   */
>> -               f->state = IAVF_VLAN_ACTIVE;
>> +               f->state = IAVF_VLAN_ADD;
>> +               iavf_schedule_aq_request(adapter,
>> +                                        IAVF_FLAG_AQ_ADD_VLAN_FILTER);
>>          }
>>
>>   clearout:
>> --
>> 2.52.0
>>


  reply	other threads:[~2026-02-25 14:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 10:01 Petr Oros
2026-02-25 11:17 ` [Intel-wired-lan] " Michal Schmidt
2026-02-25 14:57   ` Petr Oros [this message]
2026-03-11 12:33     ` Romanowski, Rafal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d93637e-cc59-45e5-9365-8140f53e4004@redhat.com \
    --to=poros@redhat.com \
    --cc=ahmed.zaki@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=przemyslaw.kitszel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®