[PATCH 0/2] cpupower: Add 'uninstall' targers for arch-related debug subprojects

[PATCH 0/2] cpupower: Add 'uninstall' targers for arch-related debug subprojects

[Roman Storozhenko]

This patch series adds 'uninstall' targets to the makefiles of
'debug/i386' and 'debug/x86_64' architecture-specifics debug subprojects

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
Roman Storozhenko (2):
      cpupower: Add 'uninstall' target for 'debug/i386' subproject
      cpupower: Add 'uninstall' target for 'debug/x86_64' subproject

 tools/power/cpupower/debug/i386/Makefile   | 8 +++++++-
 tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
 2 files changed, 12 insertions(+), 2 deletions(-)
---
base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
change-id: 20240625-add_uninstall-14246eeec69a

Best regards,
-- 
Roman Storozhenko <romeusmeister@gmail.com>

[PATCH 1/2] cpupower: Add 'uninstall' target for 'debug/i386' subproject

[Roman Storozhenko]

Add 'uninstall' target for the 'debug/i386' subproject.
The target removes binaries previously installed to the
'${DESTDIR}${bindir}' dir.

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
 tools/power/cpupower/debug/i386/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/power/cpupower/debug/i386/Makefile b/tools/power/cpupower/debug/i386/Makefile
index b3f771039b17..355f44dafa00 100644
--- a/tools/power/cpupower/debug/i386/Makefile
+++ b/tools/power/cpupower/debug/i386/Makefile
@@ -39,4 +39,10 @@ install:
 	$(INSTALL) $(OUTPUT)dump_psb $(DESTDIR)${bindir}
 	$(INSTALL) $(OUTPUT)intel_gsic $(DESTDIR)${bindir}
 
-.PHONY: all default clean install
+uninstall:
+	- rm -f $(DESTDIR)${bindir}/centrino-decode
+	- rm -f $(DESTDIR)${bindir}/powernow-k8-decode
+	- rm -f $(DESTDIR)${bindir}/dump_psb
+	- rm -f $(DESTDIR)${bindir}/intel_gsic
+
+.PHONY: all default clean install uninstall

-- 
2.34.1

[PATCH 2/2] cpupower: Add 'uninstall' target for 'debug/x86_64' subproject

[Roman Storozhenko]

Add 'uninstall' target for the 'debug/x86_64' subproject.
The target removes binaries previously installed to the
'${DESTDIR}${bindir}' dir.

Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
 tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
index b1b6c43644e7..37fd414835b8 100644
--- a/tools/power/cpupower/debug/x86_64/Makefile
+++ b/tools/power/cpupower/debug/x86_64/Makefile
@@ -28,4 +28,8 @@ install:
 	$(INSTALL) $(OUTPUT)centrino-decode $(DESTDIR)${bindir}
 	$(INSTALL) $(OUTPUT)powernow-k8-decode $(DESTDIR)${bindir}
 
-.PHONY: all default clean install
+uninstall:
+	- rm -f $(DESTDIR)${bindir}/centrino-decode
+	- rm -f $(DESTDIR)${bindir}/powernow-k8-decode
+
+.PHONY: all default clean install uninstall

-- 
2.34.1

Re: [PATCH 0/2] cpupower: Add 'uninstall' targers for arch-related debug subprojects

[Shuah Khan]

On 6/25/24 12:53, Roman Storozhenko wrote:
> This patch series adds 'uninstall' targets to the makefiles of
> 'debug/i386' and 'debug/x86_64' architecture-specifics debug subprojects
> 
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> Roman Storozhenko (2):
>        cpupower: Add 'uninstall' target for 'debug/i386' subproject
>        cpupower: Add 'uninstall' target for 'debug/x86_64' subproject
> 
>   tools/power/cpupower/debug/i386/Makefile   | 8 +++++++-
>   tools/power/cpupower/debug/x86_64/Makefile | 6 +++++-
>   2 files changed, 12 insertions(+), 2 deletions(-)
> ---
> base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
> change-id: 20240625-add_uninstall-14246eeec69a
> 
> Best regards,

I am inclined to not take these as these are special case
debug tools and modules for developers.

thanks,
-- Shuah