From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sebastian Reichel <sre@kernel.org>,
Sven Van Asbroeck <thesven73@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] max17042_battery: fix model download bug.
Date: Wed, 10 Aug 2016 10:27:07 +0200 [thread overview]
Message-ID: <6db1eb24-d659-e424-9da7-39cabd6ad5ee@samsung.com> (raw)
In-Reply-To: <20160809185429.GB19946@earth>
On 08/09/2016 08:54 PM, Sebastian Reichel wrote:
> Hi,
>
> [adding some people to CC]
>
> On Wed, Aug 03, 2016 at 10:03:46AM -0400, Sven Van Asbroeck wrote:
>> The device's model download function returns the model data as
>> an array of u32s, which is later compared to the reference
>> model data. However, since the latter is an array of u16s,
>> the comparison does not happen correctly, and model verification
>> fails. This in turn breaks the POR initialization sequence.
>
> Patch looks ok, except for missing Fixes. I guess it should be
> "Fixes: 39e7213edc4f3". I will wait with queuing it for a few
> days giving Samsung people a chance to reply.
Looks correct.
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Also:
Cc: <stable@vger.kernel.org>
And how about:
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
https://www.marc.info/?l=linux-pm&m=143954612610000&w=4
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-08-10 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 14:03 Sven Van Asbroeck
2016-08-09 18:54 ` Sebastian Reichel
2016-08-10 8:27 ` Krzysztof Kozlowski [this message]
2016-08-12 0:59 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db1eb24-d659-e424-9da7-39cabd6ad5ee@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome