* [PATCH] arm64: dts: mediatek: mt7981b: Add PMU
@ 2026-05-02 7:49 Peter Collingbourne
2026-05-05 6:49 ` Sjoerd Simons
0 siblings, 1 reply; 3+ messages in thread
From: Peter Collingbourne @ 2026-05-02 7:49 UTC (permalink / raw)
To: Sjoerd Simons
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, Peter Collingbourne
The interrupt number was taken from a downstream DTS of the similar MT7987
[1] and verified on my OpenWrt One.
Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
Link: [1] https://github.com/openwrt/openwrt/blob/e4b3d5c799aef3be20b7f6079e8e5a14b215c116/target/linux/mediatek/dts/mt7987.dtsi#L246
---
arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
index 4084f4dfa3e5..3c6fbb6c5333 100644
--- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
@@ -38,6 +38,12 @@ oscillator-40m {
#clock-cells = <0>;
};
+ pmu {
+ compatible = "arm,cortex-a53-pmu";
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
+ };
+
psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.54.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt7981b: Add PMU
2026-05-02 7:49 [PATCH] arm64: dts: mediatek: mt7981b: Add PMU Peter Collingbourne
@ 2026-05-05 6:49 ` Sjoerd Simons
2026-05-14 6:45 ` Peter Collingbourne
0 siblings, 1 reply; 3+ messages in thread
From: Sjoerd Simons @ 2026-05-05 6:49 UTC (permalink / raw)
To: Peter Collingbourne
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
On Sat, 2026-05-02 at 00:49 -0700, Peter Collingbourne wrote:
> The interrupt number was taken from a downstream DTS of the similar MT7987
> [1] and verified on my OpenWrt One.
>
> Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
> Link: [1]
> https://github.com/openwrt/openwrt/blob/e4b3d5c799aef3be20b7f6079e8e5a14b215c116/target/linux/mediatek/dts/mt7987.dtsi#L246
> ---
> arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 4084f4dfa3e5..3c6fbb6c5333 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -38,6 +38,12 @@ oscillator-40m {
> #clock-cells = <0>;
> };
>
> + pmu {
> + compatible = "arm,cortex-a53-pmu";
> + interrupt-parent = <&gic>;
The parent node already specifies the interrupt-parent, so this is redundant.
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
Otherwise looks good
Regards,
--
Sjoerd Simons
Collabora
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt7981b: Add PMU
2026-05-05 6:49 ` Sjoerd Simons
@ 2026-05-14 6:45 ` Peter Collingbourne
0 siblings, 0 replies; 3+ messages in thread
From: Peter Collingbourne @ 2026-05-14 6:45 UTC (permalink / raw)
To: Sjoerd Simons
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
On Mon, May 4, 2026 at 11:49 PM Sjoerd Simons <sjoerd@collabora.com> wrote:
>
> On Sat, 2026-05-02 at 00:49 -0700, Peter Collingbourne wrote:
> > The interrupt number was taken from a downstream DTS of the similar MT7987
> > [1] and verified on my OpenWrt One.
> >
> > Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
> > Link: [1]
> > https://github.com/openwrt/openwrt/blob/e4b3d5c799aef3be20b7f6079e8e5a14b215c116/target/linux/mediatek/dts/mt7987.dtsi#L246
> > ---
> > arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> > index 4084f4dfa3e5..3c6fbb6c5333 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> > @@ -38,6 +38,12 @@ oscillator-40m {
> > #clock-cells = <0>;
> > };
> >
> > + pmu {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupt-parent = <&gic>;
>
> The parent node already specifies the interrupt-parent, so this is redundant.
>
> > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > + };
> > +
>
> Otherwise looks good
Thanks, sent v2 with removed interrupt-parent.
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-14 6:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-02 7:49 [PATCH] arm64: dts: mediatek: mt7981b: Add PMU Peter Collingbourne
2026-05-05 6:49 ` Sjoerd Simons
2026-05-14 6:45 ` Peter Collingbourne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®