From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Rafał Miłecki" <rafal@milecki.pl>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Andrew Lunn" <andrew@lunn.ch>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/2] net: phy: rework Kconfig settings for MDIO_BUS
Date: Wed, 28 Jun 2017 16:17:54 -0700 [thread overview]
Message-ID: <6ddd0a30-cd29-a05a-01e3-b523689271e4@gmail.com> (raw)
In-Reply-To: <20170621220626.46691-1-arnd@arndb.de>
On 06/21/2017 03:06 PM, Arnd Bergmann wrote:
> I still see build errors in randconfig builds and have had this
> patch for a while to locally work around it:
>
> drivers/built-in.o: In function `xgene_mdio_probe':
> mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register'
> mux-core.c:(.text+0x352168): undefined reference to `mdiobus_free'
> mux-core.c:(.text+0x3521c0): undefined reference to `mdiobus_alloc_size'
>
> The idea is that CONFIG_MDIO_BUS now reflects whether the mdio_bus
> code is built-in or a module, and other drivers that use the core
> code can simply depend on that, instead of having a complex
> dependency line.
>
> Fixes: 90eff9096c01 ("net: phy: Allow splitting MDIO bus/device support from PHYs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
This looks a lot better indeed, thanks!
--
Florian
prev parent reply other threads:[~2017-06-28 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 22:06 Arnd Bergmann
2017-06-21 22:06 ` [RFC 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency Arnd Bergmann
2017-06-28 23:18 ` Florian Fainelli
2017-06-28 23:17 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddd0a30-cd29-a05a-01e3-b523689271e4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®