mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: apw@canonical.com, akpm@linux-foundation.org, elver@google.com,
	 linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v1] checkpatch: Add context-analysis attributes
Date: Sun, 15 Nov 2026 20:18:50 -0800	[thread overview]
Message-ID: <6e18f4dfbe3187e7ea35f61c4fb9d27443fd892d.camel@perches.com> (raw)
In-Reply-To: <avngL4BZlQTv2OHO@google.com>

On Sun, 2026-11-15 at 16:39 +0000, Vincent Donnefort wrote:
> On Sat, Nov 14, 2026 at 06:57:39AM -0800, Joe Perches wrote:
> > On Sat, 2026-11-14 at 06:26 -0800, Joe Perches wrote:
> > > > How about matching one internal () pair?
> > > > 
> > > > __guarded_by\s*\(
> > > > 	(?:
> > > > 		[^()]++ |
> > > > 		\([^()]*+\)
> > > > 	)*+
> > > > \)
> > > 
> > > Sure.
> > > Please add and use another variable so it's not repeated everywhere.
> > 
> > Reading a bit about balanced parentheses in perl '(?R)'
> > non capturing recursion works since 5.10.0
> > 
> > Maybe instead use
> > 
> > /\((?:[^()]++|(?R))*\)/
> 
> Somehow it doesn't work. I have tried the following:
> 
>   my $p = qr/\((?:[^()]++|(?R))*\)/;
>   my $a = qr/__guarded_by\s*$p/;
>   for my $s ("__guarded_by(&mutex)", "__guarded_by(foobar())") {
>   	print "$s:", ($s =~ /^$a$/ ? "ok" : "nope"), "\n";
>   }'
> 
>   __guarded_by(&mutex): ok
>   __guarded_by(foobar()): nope
> 
> Did I miss something?

Dunno.

The only thing I got to work was using a capture group
in the additional string.

  my $balanced_parens = qr{\s*((?x: \( (?: [^()]++ | (?-1) )* \) ))};
  
  for my $s ("__guarded_by  (&mutex)", "__guarded_by(foobar(qux(baz())))") {
      if ($s =~ /__guarded_by$balanced_parens/) {
	  print("ok: $s: <$1>\n");
      } else {
	  print("nope: $s: <$1>\n");
      }
  }

      reply	other threads:[~2026-11-16  4:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 15:12 Vincent Donnefort
2026-11-12 15:23 ` Marco Elver
2026-11-13  3:32 ` Joe Perches
2026-11-14 13:21   ` Vincent Donnefort
2026-11-14 14:26     ` Joe Perches
2026-11-14 14:57       ` Joe Perches
2026-11-15 16:39         ` Vincent Donnefort
2026-11-16  4:18           ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e18f4dfbe3187e7ea35f61c4fb9d27443fd892d.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=elver@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®