From: Joe Perches <joe@perches.com>
To: Dan Murphy <dmurphy@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
davem@davemloft.net, andrew@lunn.ch, hkallweit1@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues
Date: Thu, 03 Sep 2020 09:54:13 -0700 [thread overview]
Message-ID: <6e223efabb08b0203ac650caeffc05a48cd0b170.camel@perches.com> (raw)
In-Reply-To: <4d38ac31-8646-2c4f-616c-1a1341721819@ti.com>
On Thu, 2020-09-03 at 11:41 -0500, Dan Murphy wrote:
> On 9/3/20 11:34 AM, Florian Fainelli wrote:
> > On 9/3/2020 7:15 AM, Dan Murphy wrote:
> > > Fix spacing issues reported for misaligned switch..case and extra new
> > > lines.
[]
> > > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
[]
> > > @@ -35,7 +34,7 @@
> > > #define DP83867_CFG4_SGMII_ANEG_MASK (BIT(5) | BIT(6))
> > > #define DP83867_CFG4_SGMII_ANEG_TIMER_11MS (3 << 5)
> > > #define DP83867_CFG4_SGMII_ANEG_TIMER_800US (2 << 5)
> > > -#define DP83867_CFG4_SGMII_ANEG_TIMER_2US (1 << 5)
> > > +#define DP83867_CFG4_SGMII_ANEG_TIMER_2US BIT(5)
> > Now the definitions are inconsistent, you would want to drop this one
> > and stick to the existing style.
>
> OK I was a little conflicted making that change due to the reasons you
> mentioned. But if that is an acceptable warning I am ok with it.
Maybe use GENMASK for DP83867_CFG4_SGMII_ANEG_MASK instead.
next prev parent reply other threads:[~2020-09-03 16:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:15 Dan Murphy
2020-09-03 16:34 ` Florian Fainelli
2020-09-03 16:41 ` Dan Murphy
2020-09-03 16:51 ` Florian Fainelli
2020-09-03 16:54 ` Joe Perches [this message]
2020-09-03 20:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e223efabb08b0203ac650caeffc05a48cd0b170.camel@perches.com \
--to=joe@perches.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®