mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
To: Danilo Krummrich <dakr@kernel.org>, Philipp Stanner <phasta@mailbox.org>
Cc: phasta@kernel.org, Luke.Wildhardt@proton.me,
	"matthew.brost@intel.com" <matthew.brost@intel.com>,
	"ckoenig.leichtzumerken@gmail.com"
	<ckoenig.leichtzumerken@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [REGRESSION] drm/sched: FAIR policy causes serious performance degradation at max GPU load on 9070XT
Date: Mon, 10 Aug 2026 14:48:13 +0100	[thread overview]
Message-ID: <6e2a207e-4db6-4d47-b1f6-9cb13b8d6eeb@igalia.com> (raw)
In-Reply-To: <DKL9VAWD2Y98.RBQPQUL7Y47F@kernel.org>


On 10/08/2026 13:45, Danilo Krummrich wrote:
> On Mon Aug 10, 2026 at 10:28 AM CEST, Philipp Stanner wrote:
>>> Reverted Commits:
>>>
>>> d09339388b77 drm/sched: Remove drm_sched_init_args->num_rqs
>>> 2833a0512b4c drm/sched: Remove drm_sched_init_args->num_rqs usage
>>> 16e7698bc04d drm/sched: Embed run queue singleton into the scheduler
>>> 77a6809f1dc3 drm/sched: Remove FIFO and RR and simplify to a single run queue
>>> 45c211ddf92a drm/sched: Switch default policy to fair
>>> 2462a0ce23b0 drm/amdgpu: Remove drm_sched_init_args->num_rqs usage
> 
> [...]
> 
>> That might be the wisest thing to do; but let's hear if Tvrtko has an idea for
>> a hotfix first.
> 
> -rc7 was released yesterday; even with a working hotfix today it'd be tricky to
> ensure the hotfix does not regress other drivers or workloads with 7.2 being
> just a few days ahead.
> 
> I suggest to not wait and get the reverts ready.

Yes reverts would be safer. I have them in a branch at 
people.freedesktop.org/~tursulin/drm-intel drm-sched-fair-reverts, 
mostly straightforward apart from one easy conflict in 
amdgpu_xcp_release_sched. Smoke tested on Steam Deck looks fine.

Having said that, the fix for min_vruntime handling I provided earlier 
in the thread also looks fine in my testing and is simple. No 
regressions found with synthetic unit test workloads or messing around 
on the Steam Deck. But we need to wait to hear from Luke since I haven't 
been able to repro his report locally yet.

Regards,

Tvrtko


  reply	other threads:[~2026-08-10 13:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 23:33 Luke.Wildhardt
2026-08-10  8:28 ` Philipp Stanner
2026-08-10 12:45   ` Danilo Krummrich
2026-08-10 13:48     ` Tvrtko Ursulin [this message]
2026-08-10 16:40       ` Luke.Wildhardt
2026-08-11  7:29         ` Philipp Stanner
2026-08-11  7:49         ` Tvrtko Ursulin
2026-08-11 17:59         ` Luke.Wildhardt
2026-08-12 11:37           ` Tvrtko Ursulin
2026-08-12 11:58             ` Philipp Stanner
2026-08-12 12:29               ` Tvrtko Ursulin
2026-09-16  7:37                 ` Philipp Stanner
2026-08-12 15:12             ` Luke.Wildhardt
2026-08-13  6:42               ` Luke.Wildhardt
2026-08-13  7:58                 ` Tvrtko Ursulin
2026-08-13 14:27                   ` Luke.Wildhardt
2026-08-14  6:49                     ` Luke.Wildhardt
2026-08-14  8:32                     ` Feng, Kenneth
2026-08-10 11:36 ` Tvrtko Ursulin
2026-08-11  7:46 ` Tvrtko Ursulin
2026-08-12  4:52   ` Luke.Wildhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e2a207e-4db6-4d47-b1f6-9cb13b8d6eeb@igalia.com \
    --to=tvrtko.ursulin@igalia.com \
    --cc=Luke.Wildhardt@proton.me \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ckoenig.leichtzumerken@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=phasta@kernel.org \
    --cc=phasta@mailbox.org \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®