Re: [PATCH 2/2] arm64: dts: qcom: Add qcs9075-radxa-airbox-q900

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 3/18/26 9:36 AM, Mecid Urganci wrote:
> Add device tree support for the Radxa AirBox Q900 board based on the
> Qualcomm QCS9075 SoC (Lemans Family).
> 
> This board features HDMI 2.0 via dp0, 2x USB 3.1 Gen 2 ports,
> 2x 2.5GbE Ethernet ports and onboard UFS storage.
> 
> Further information: https://radxa.com/products/fogwise/airbox-q900/
> 
> Functionality has been tested and confirmed working via an Armbian
> Debian Trixie build.
> 
> Signed-off-by: Mecid Urganci <mecid@mecomediagroup.de>
> Made-with: Cursor
> ---

[...]

> +	gpio_leds: gpio-leds {

Please strip unused labels

> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&status_led_state>, <&power_led_state>;

property-n
property-names

in this order, file-wide, please

[...]


> +		vreg_l4c: ldo4 {
> +			regulator-name = "vreg_l4c";
> +			regulator-min-microvolt = <1200000>;
> +			regulator-max-microvolt = <1200000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +			/*
> +			 * FIXME: This should have regulator-allow-set-load but
> +			 * we're getting an over-current fault from the PMIC
> +			 * when switching to LPM.
> +			 */

Are you actually experiencing that, or is that a copy-pasta?

[...]

> +&i2c15 {
> +	clock-frequency = <400000>;
> +	status = "okay";

Please uniformly keep a \n before 'status'

[...]


> +&gpu_zap_shader {
> +	firmware-name = "qcom/sa8775p/a663_zap.mbn";
> +};
> +
> +&iris {
> +	firmware-name = "qcom/vpu/vpu30_p4_s6.mbn";
> +	status = "okay";
> +};

Those are only Qualcomm-signed (i.e. not vendor-signed) - are you
using the ones from linux-firmware?

[...]

> +&remoteproc_adsp {
> +	firmware-name = "qcom/sa8775p/adsp.mbn";

Notably the ADSP firmware normally contains board-specific modifications..

[...]

> +	power_led_state: power-led-state {
> +		pins = "gpio98";
> +		function = "gpio";
> +		output-high;

You're already manipulating this pin from the gpio-leds node, no need

> +		bias-pull-up;

pull-up of an active-high pin sounds odd

Konrad