* [kernel PATCH v2 0/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
@ 2022-08-23 4:44 Zhengping Jiang
2022-08-23 4:44 ` [kernel PATCH v2 1/1] " Zhengping Jiang
0 siblings, 1 reply; 3+ messages in thread
From: Zhengping Jiang @ 2022-08-23 4:44 UTC (permalink / raw)
To: linux-bluetooth, marcel
Cc: chromeos-bluetooth-upstreaming, Zhengping Jiang, David S. Miller,
Eric Dumazet, Jakub Kicinski, Johan Hedberg,
Luiz Augusto von Dentz, Paolo Abeni, linux-kernel, netdev
Hold hdev->lock for hci_conn_failed. There are possible race conditions
which may cause kernel crash.
Changes in v2:
- Update commit message
Changes in v1:
- Hold hdev->lock for hci_conn_failed
Zhengping Jiang (1):
Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
net/bluetooth/hci_sync.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--
2.37.1.595.g718a3a8f04-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* [kernel PATCH v2 1/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
2022-08-23 4:44 [kernel PATCH v2 0/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn Zhengping Jiang
@ 2022-08-23 4:44 ` Zhengping Jiang
2022-08-23 11:06 ` Paolo Abeni
0 siblings, 1 reply; 3+ messages in thread
From: Zhengping Jiang @ 2022-08-23 4:44 UTC (permalink / raw)
To: linux-bluetooth, marcel
Cc: chromeos-bluetooth-upstreaming, Zhengping Jiang, David S. Miller,
Eric Dumazet, Jakub Kicinski, Johan Hedberg,
Luiz Augusto von Dentz, Paolo Abeni, linux-kernel, netdev
When disconnecting all devices, hci_conn_failed is used to cleanup
hci_conn object when the hci_conn object cannot be aborted.
The function hci_conn_failed requires the caller holds hdev->lock.
Fixes: 9b3628d79b46f ("Bluetooth: hci_sync: Cleanup hci_conn if it cannot be aborted")
Signed-off-by: Zhengping Jiang <jiangzp@google.com>
---
Changes in v2:
- Update commit message
Changes in v1:
- Hold hdev->lock for hci_conn_failed
net/bluetooth/hci_sync.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 74a0cd5d0b37f..e08c0503027d8 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -5034,9 +5034,11 @@ int hci_abort_conn_sync(struct hci_dev *hdev, struct hci_conn *conn, u8 reason)
/* Cleanup hci_conn object if it cannot be cancelled as it
* likelly means the controller and host stack are out of sync.
*/
- if (err)
+ if (err) {
+ hci_dev_lock(hdev);
hci_conn_failed(conn, err);
-
+ hci_dev_unlock(hdev);
+ }
return err;
case BT_CONNECT2:
return hci_reject_conn_sync(hdev, conn, reason);
--
2.37.1.595.g718a3a8f04-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kernel PATCH v2 1/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn
2022-08-23 4:44 ` [kernel PATCH v2 1/1] " Zhengping Jiang
@ 2022-08-23 11:06 ` Paolo Abeni
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2022-08-23 11:06 UTC (permalink / raw)
To: Zhengping Jiang, linux-bluetooth, marcel
Cc: chromeos-bluetooth-upstreaming, David S. Miller, Eric Dumazet,
Jakub Kicinski, Johan Hedberg, Luiz Augusto von Dentz,
linux-kernel, netdev
On Mon, 2022-08-22 at 21:44 -0700, Zhengping Jiang wrote:
> When disconnecting all devices, hci_conn_failed is used to cleanup
> hci_conn object when the hci_conn object cannot be aborted.
> The function hci_conn_failed requires the caller holds hdev->lock.
>
> Fixes: 9b3628d79b46f ("Bluetooth: hci_sync: Cleanup hci_conn if it cannot be aborted")
>
> Signed-off-by: Zhengping Jiang <jiangzp@google.com>
For the records, you should avoid empty lines between the 'fixes' tag
and your SoB.
Cheers,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-23 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 4:44 [kernel PATCH v2 0/1] Bluetooth: hci_sync: hold hdev->lock when cleanup hci_conn Zhengping Jiang
2022-08-23 4:44 ` [kernel PATCH v2 1/1] " Zhengping Jiang
2022-08-23 11:06 ` Paolo Abeni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®