mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mieczyslaw Nalewaj <namiltd@yahoo.com>
To: Gustavo Foletto Mora <gusfmora@gmail.com>,
	Linus Walleij <linusw@kernel.org>
Cc: andrew@lunn.ch, olteanv@gmail.com, kuba@kernel.org,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	linux@armlinux.org.uk, luizluca@gmail.com,
	maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, alvin.sipraga@analog.com,
	kuncy7@gmail.com, fabianotassotti@gmail.com,
	gabonpivovich@gmail.com, contact@c127.dev
Subject: Re: [PATCH net-next v11 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D
Date: Wed, 18 Nov 2026 08:59:38 +0100	[thread overview]
Message-ID: <6e61078d-45a5-4ebf-9dc3-a74b80a637f3@yahoo.com> (raw)
In-Reply-To: <CAK+kzgwVSG4CBv8NQvQaqyr__BZbd860EDfEMoZU5JdFCYhtTw@mail.gmail.com>

Subject: Re: [PATCH net-next v11 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D

Hi Gustavo,

Thanks for testing v11, and for the detailed report on the vlan_filtering toggle. I will add your Tested-by on 7, 8 and 9 in the next revision, noting for 8 and 9 that it is family D only.

On the 5.4 s per toggle: agreed, scanning all 4095 entries over MDIO is too slow. I plan to track the VIDs that are in use and scan only those in rtl8365mb_d_vlan_4k_refresh_ivl().

I also have a question where your hardware would help. The Sashiko review of v11 12/13 (https://sashiko.dev/#/patchset/cf3fd237-2290-4002-8de0-ea4100ef0f85%40yahoo.com, "Muted" so it did not go to the list) raises the same shared-FID problem you reported earlier. It says:

> Does sharing SVL FID 0 between standalone ports and an offloaded
> VLAN-unaware bridge break DSA standalone port isolation?
> [...]
> Once a MAC is learned or programmed on an offloaded bridge port in
> FID 0, any frame arriving on a standalone or software-bridged port for
> that destination MAC hits the bridge port entry instead of flooding to the
> CPU port, and is dropped by the ingress port's isolation mask.

and suggests a way out:

> Commit "net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D"
> defines a 2-bit FID field (RTL8365MB_D_CVLAN_ENTRY_D1_FID_MASK) in the
> family D CVLAN entry and rtl8365mb_d_l2_uc_to_data() already serializes
> uc->key.fid when ivl is false, so could the offloaded bridge be assigned a
> non-zero SVL FID to keep it separate from FID 0 on standalone ports?

I cannot verify this from the vendor API alone. What I would like to know, if you have time to try it on the EX511:

1. With IVL_EN=0 (VLAN-unaware bridge), if the FID field of the bridge VLAN's 4K entry is set to 1 (for example by a temporary hack in rtl8365mb_vlan_4k_port_set()), does the chip learn the bridge hosts with FID 1? A debug print of key.fid in rtl8365mb_d_l2_data_to_uc() on the learned entries should show it.
2. Which VLAN4K entry do the standalone ports classify into with PVID 0? If it is not the same entry, they would stay in FID 0 and the bridge could use another FID. If it is the same entry, the FID cannot separate them.
3. If 1 and 2 work out, do static entries written with key.fid = 1 replace the learned ones?

If you see that the chip does not use the VLAN4K FID for learning, I will keep this as a documented limitation in the commit message, as it is now. If it does, I will look at giving the offloaded bridge its own FID in a follow-up, with FDB/MDB entries for the bridge keyed with that FID and standalone ports left on FID 0.

Thanks,
Mieczyslaw

  reply	other threads:[~2026-11-18  7:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cf3fd237-2290-4002-8de0-ea4100ef0f85.ref@yahoo.com>
2026-11-17  7:34 ` [PATCH net-next v11 00/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj
2026-11-17  7:35   ` [PATCH net-next v11 01/13] dt-bindings: net: dsa: realtek: add RTL8367S-VB Mieczyslaw Nalewaj
2026-11-17  7:36   ` [PATCH net-next v11 02/13] net: dsa: realtek: rtl8365mb: add chip family infrastructure Mieczyslaw Nalewaj
2026-11-17  7:36   ` [PATCH net-next v11 03/13] net: dsa: realtek: rtl8365mb: refactor forcemode handling Mieczyslaw Nalewaj
2026-11-17  7:37   ` [PATCH net-next v11 04/13] net: dsa: realtek: rtl8365mb: set speed for family D Mieczyslaw Nalewaj
2026-11-17  7:38   ` [PATCH net-next v11 05/13] net: dsa: realtek: rtl8365mb: set RGMII mode " Mieczyslaw Nalewaj
2026-11-17  7:38   ` [PATCH net-next v11 06/13] net: dsa: realtek: rtl8365mb: refactor VLAN 4k handling Mieczyslaw Nalewaj
2026-11-17  7:39   ` [PATCH net-next v11 07/13] net: dsa: realtek: rtl8365mb: set and get vlan 4k for family D Mieczyslaw Nalewaj
2026-11-17  8:23     ` Linus Walleij
2026-11-18  1:48       ` Gustavo Foletto Mora
2026-11-18  7:59         ` Mieczyslaw Nalewaj [this message]
2026-11-17  7:39   ` [PATCH net-next v11 08/13] net: dsa: realtek: rtl8365mb: refactor PVID handling Mieczyslaw Nalewaj
2026-11-17  8:34     ` Linus Walleij
2026-11-17  8:53       ` Mieczyslaw Nalewaj
2026-11-18  1:55     ` Gustavo Foletto Mora
2026-11-17  7:40   ` [PATCH net-next v11 09/13] net: dsa: realtek: rtl8365mb: use raw VID for PVID on family D Mieczyslaw Nalewaj
2026-11-18  2:00     ` Gustavo Foletto Mora
2026-11-17  7:41   ` [PATCH net-next v11 10/13] net: dsa: realtek: rtl8365mb: add family D SDS13 PCS support Mieczyslaw Nalewaj
2026-11-17  7:41   ` [PATCH net-next v11 11/13] net: dsa: realtek: rtl8365mb: refactor L2 MAC handling Mieczyslaw Nalewaj
2026-11-17  7:42   ` [PATCH net-next v11 12/13] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D Mieczyslaw Nalewaj
2026-11-17  7:43   ` [PATCH net-next v11 13/13] net: dsa: realtek: rtl8365mb: add support for RTL8367S-VB Mieczyslaw Nalewaj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e61078d-45a5-4ebf-9dc3-a74b80a637f3@yahoo.com \
    --to=namiltd@yahoo.com \
    --cc=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=contact@c127.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fabianotassotti@gmail.com \
    --cc=gabonpivovich@gmail.com \
    --cc=gusfmora@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuncy7@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luizluca@gmail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®