From: Dave Hansen <dave.hansen@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Noah Goldstein <goldstein.w.n@gmail.com>,
Alexander Duyck <alexanderduyck@fb.com>
Subject: Re: [PATCH] x86/csum: fix initial seed for odd buffers
Date: Tue, 30 Nov 2021 14:16:17 -0800 [thread overview]
Message-ID: <6e94236d-7e91-80a6-f55d-15bd503e52c4@intel.com> (raw)
In-Reply-To: <20211125141817.3541501-1-eric.dumazet@gmail.com>
On 11/25/21 6:18 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> When I folded do_csum() into csum_partial(), I missed that we
> had to swap odd/even bytes from @sum argument.
...
> Fixes: df4554cebdaa ("x86/csum: Rewrite/optimize csum_partial()")
Hi Eric,
That Fixes: sha1 doesn't match anything that I can find. Should it be
Fixes: this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/core&id=d31c3c683ee668ba5d87c0730610442fd672525f
I'm happy to fix it up when I apply it. Just wanted to double-check
what you intended.
next prev parent reply other threads:[~2021-11-30 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 14:18 Eric Dumazet
2021-11-30 22:16 ` Dave Hansen [this message]
2021-12-01 0:18 ` Eric Dumazet
2021-12-01 0:33 ` [tip: x86/core] x86/csum: Fix " tip-bot2 for Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e94236d-7e91-80a6-f55d-15bd503e52c4@intel.com \
--to=dave.hansen@intel.com \
--cc=alexanderduyck@fb.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=goldstein.w.n@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®