mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>,
	apw@canonical.com, nickhu@andestech.com, green.hu@gmail.com,
	deanbo422@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS add D: tag for subsystem commit prefix
Date: Sat, 28 Nov 2020 08:00:04 -0800	[thread overview]
Message-ID: <6e9917257cfd6774066446014051d39b784ba497.camel@perches.com> (raw)
In-Reply-To: <f96ff56c-7c39-2fed-dd8b-11971f8965bf@redhat.com>

On Sat, 2020-11-28 at 07:36 -0800, Tom Rix wrote:
> On 11/27/20 2:10 PM, Joe Perches wrote:
[]
> > I think an exception mechanism would be better than a specific
> > mechanism added to various entries.
> Can you give an example of what you mean ?

Inherit the parent prefix then add the basename(dirname) as a default.

For instance, changes to any subsystem of drivers/staging starts as
"staging: " and with "$basename(path): " appended.

So the MAINTAINERS entry for staging could be:

STAGING SUBSYSTEM
M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
L:	devel@driverdev.osuosl.org
S:	Supported
T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
D:	"staging: "
F:	drivers/staging/

Any specified D: use would override the generic form.

And generic ARM changes could use the same mechanism with:

ARM PORT
M:	Russell King <linux@armlinux.org.uk>
L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
S:	Odd Fixes
W:	http://www.armlinux.org.uk/
T:	git git://git.armlinux.org.uk/~rmk/linux-arm.git
D:	"ARM: "
F:	arch/arm/
X:	arch/arm/boot/dts/

And media likewise:

MEDIA INPUT INFRASTRUCTURE (V4L/DVB)
M:	Mauro Carvalho Chehab <mchehab@kernel.org>
L:	linux-media@vger.kernel.org
S:	Maintained
W:	https://linuxtv.org
Q:	http://patchwork.kernel.org/project/linux-media/list/
T:	git git://linuxtv.org/media_tree.git
D:	"media: "
F:	Documentation/admin-guide/media/
F:	Documentation/devicetree/bindings/media/
F:	Documentation/driver-api/media/
F:	Documentation/userspace-api/media/
F:	drivers/media/
F:	drivers/staging/media/
F:	include/linux/platform_data/media/
F:	include/media/
F:	include/uapi/linux/dvb/
F:	include/uapi/linux/ivtv*
F:	include/uapi/linux/media.h
F:	include/uapi/linux/meye.h
F:	include/uapi/linux/uvcvideo.h
F:	include/uapi/linux/v4l2-*
F:	include/uapi/linux/videodev2.h

etc...

> > >  # check MAINTAINERS entries for the right ordering too
> > > -			my $preferred_order = 'MRLSWQBCPTFXNK';
> > > +			my $preferred_order = 'MRLSWQBCPTFXNKD';
> > >  			if ($rawline =~ /^\+[A-Z]:/ &&
> > >  			    $prevrawline =~ /^[\+ ][A-Z]:/) {
> > >  				$rawline =~ /^\+([A-Z]):\s*(.*)/;
> > I'd prefer to keep the file and keyword list last.
> > 
> So change to
> 
> my $preferred_order = 'MRLSWQBCPTDFXNK'; 
> 
> ?

Right.  And update the preferred_order in scripts/parse-maintainers.pl too.




  reply	other threads:[~2020-11-28 22:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 21:43 trix
2020-11-27 22:10 ` Joe Perches
2020-11-28 15:36   ` Tom Rix
2020-11-28 16:00     ` Joe Perches [this message]
2020-11-28 16:30       ` Tom Rix
2020-11-28 16:44         ` Joe Perches
2020-11-28 16:56           ` Tom Rix
2020-11-27 22:43 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e9917257cfd6774066446014051d39b784ba497.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickhu@andestech.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®