[PATCH] USB: serial: ftdi: add CONTEC vendor and product id

[PATCH] USB: serial: ftdi: add CONTEC vendor and product id

[Daniel Sangorrin]

This is a patch to ftdi_sio_ids.h and ftdi_sio.c that adds
identifiers for CONTEC USB serial converter. I tested it
with the device COM-1(USB)H

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@gmail.com>
---
 drivers/usb/serial/ftdi_sio.c     |    1 +
 drivers/usb/serial/ftdi_sio_ids.h |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 7638828..35d4336 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -657,6 +657,7 @@ static struct usb_device_id id_table_combined [] = {
 	{ USB_DEVICE(EVOLUTION_VID, EVOLUTION_ER1_PID) },
 	{ USB_DEVICE(EVOLUTION_VID, EVO_HYBRID_PID) },
 	{ USB_DEVICE(EVOLUTION_VID, EVO_RCM4_PID) },
+	{ USB_DEVICE(CONTEC_VID, CONTEC_COM1USBH_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_ARTEMIS_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_ATIK_ATK16_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_ATIK_ATK16C_PID) },
diff --git a/drivers/usb/serial/ftdi_sio_ids.h
b/drivers/usb/serial/ftdi_sio_ids.h
index c8951ae..545db7f 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -1002,3 +1002,10 @@
 #define EVO_8U232AM_PID	0x02FF	/* Evolution robotics RCM2 (FT232AM)*/
 #define EVO_HYBRID_PID		0x0302	/* Evolution robotics RCM4 PID (FT232BM)*/
 #define EVO_RCM4_PID		0x0303	/* Evolution robotics RCM4 PID */
+
+/*
+ * Contec products (http://www.contec.com)
+ * Submitted by Daniel Sangorrin
+ */
+#define CONTEC_VID		0x06CE	/* Vendor ID */
+#define CONTEC_COM1USBH_PID	0x8311	/* COM-1(USB)H */
-- 
1.6.0.4

Re: [PATCH] USB: serial: ftdi: add CONTEC vendor and product id

[Andreas Mohr]

Hi,

On Sat, Feb 20, 2010 at 10:20:50PM +0900, Daniel Sangorrin wrote:
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h
> b/drivers/usb/serial/ftdi_sio_ids.h
> index c8951ae..545db7f 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -1002,3 +1002,10 @@
>  #define EVO_8U232AM_PID	0x02FF	/* Evolution robotics RCM2 (FT232AM)*/
>  #define EVO_HYBRID_PID		0x0302	/* Evolution robotics RCM4 PID (FT232BM)*/
>  #define EVO_RCM4_PID		0x0303	/* Evolution robotics RCM4 PID */
> +
> +/*
> + * Contec products (http://www.contec.com)
> + * Submitted by Daniel Sangorrin
> + */
> +#define CONTEC_VID		0x06CE	/* Vendor ID */
> +#define CONTEC_COM1USBH_PID	0x8311	/* COM-1(USB)H */

This VID is not sorted (which also leads to a possibility of merge conflicts),
perhaps resubmit?

Apart from this: ACK (not that there would be much to not ACK here
though :)

Thanks for notifying driver stakeholders (I should have actually decided
to list my email address, too, though).

Thanks,

Andreas Mohr

[PATCH resubmit] USB: serial: ftdi: add CONTEC vendor and product id

[Daniel Sangorrin]

Hi

> Andreas Mohr:
> This VID is not sorted (which also leads to a possibility of merge conflicts),
> perhaps resubmit?

Sorry (^^), here is the new patch. Hope it is sorted now (although in
ftdi_sio.c it didnt seem to be sorted)

From: Daniel Sangorrin <daniel.sangorrin@gmail.com>
Date: Mon, 22 Feb 2010 10:51:50 +0900
Subject: [PATCH] USB: serial: ftdi: add CONTEC vendor and product id

This is a patch to ftdi_sio_ids.h and ftdi_sio.c that adds
identifiers for CONTEC USB serial converter. I tested it
with the device COM-1(USB)H

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@gmail.com>
---
 drivers/usb/serial/ftdi_sio.c     |    1 +
 drivers/usb/serial/ftdi_sio_ids.h |    7 +++++++
 2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 7638828..91124be 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -614,6 +614,7 @@ static struct usb_device_id id_table_combined [] = {
 	{ USB_DEVICE(FTDI_VID, FTDI_OCEANIC_PID) },
 	{ USB_DEVICE(TTI_VID, TTI_QL355P_PID) },
 	{ USB_DEVICE(FTDI_VID, FTDI_RM_CANVIEW_PID) },
+	{ USB_DEVICE(CONTEC_VID, CONTEC_COM1USBH_PID) },
 	{ USB_DEVICE(BANDB_VID, BANDB_USOTL4_PID) },
 	{ USB_DEVICE(BANDB_VID, BANDB_USTL4_PID) },
 	{ USB_DEVICE(BANDB_VID, BANDB_USO9ML2_PID) },
diff --git a/drivers/usb/serial/ftdi_sio_ids.h
b/drivers/usb/serial/ftdi_sio_ids.h
index c8951ae..6fd503b 100644
--- a/drivers/usb/serial/ftdi_sio_ids.h
+++ b/drivers/usb/serial/ftdi_sio_ids.h
@@ -494,6 +494,13 @@
 #define RATOC_PRODUCT_ID_USB60F	0xb020

 /*
+ * Contec products (http://www.contec.com)
+ * Submitted by Daniel Sangorrin
+ */
+#define CONTEC_VID		0x06CE	/* Vendor ID */
+#define CONTEC_COM1USBH_PID	0x8311	/* COM-1(USB)H */
+
+/*
  * Definitions for B&B Electronics products.
  */
 #define BANDB_VID		0x0856	/* B&B Electronics Vendor ID */
-- 
1.6.0.4

Re: [PATCH resubmit] USB: serial: ftdi: add CONTEC vendor and product id

[Andreas Mohr]

Hi,

On Mon, Feb 22, 2010 at 11:03:11AM +0900, Daniel Sangorrin wrote:
> Hi
> 
> > Andreas Mohr:
> > This VID is not sorted (which also leads to a possibility of merge conflicts),
> > perhaps resubmit?
> 
> Sorry (^^), here is the new patch. Hope it is sorted now (although in
> ftdi_sio.c it didnt seem to be sorted)

Thanks!
Yes, it's sorted. And yes, it's not sorted ;) (I didn't get around to
sorting it there yet, it's on my ToDo list).

I will also add a comment to the end of ftdi_sio_ids.h (and .c) to avoid future
(non-)sorting confusion.

Andreas Mohr