From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Jhu <stanleyjhu@google.com>,
"Martin K . Petersen" <mkp@kernel.org>,
linux-scsi@vger.kernel.org
Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Bean Huo <beanhuo@micron.com>,
Peter Wang <peter.wang@mediatek.com>,
Can Guo <can.guo@oss.qualcomm.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 4/4] scsi: ufs: core: Remove an always-false WARN_ONCE()
Date: Mon, 19 Oct 2026 13:45:35 -0700 [thread overview]
Message-ID: <6ef38c72-9288-4d33-9f42-439c9dbd01d4@acm.org> (raw)
In-Reply-To: <20261017084403.875420-5-stanleyjhu@google.com>
On 10/17/26 1:44 AM, Stanley Jhu wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 44e571757535..716dab2352e9 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6059,9 +6059,6 @@ static unsigned long __ufshcd_clear_outstanding_reqs(struct ufs_hba *hba,
> unsigned long completed_reqs = mask & hba->outstanding_reqs;
>
> lockdep_assert_held(&hba->outstanding_lock);
> - WARN_ONCE(completed_reqs & ~hba->outstanding_reqs,
> - "completed: %#lx; outstanding: %#lx\n", completed_reqs,
> - hba->outstanding_reqs);
> if (from_irq) {
> /* Do not complete polled requests from interrupt context. */
> ufshcd_clear_polled(hba, &completed_reqs);
This patch should either be the first patch in this series or should be
squashed into patch 1/4 from this series.
Thanks,
Bart.
next prev parent reply other threads:[~2026-10-19 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 8:43 [PATCH v2 0/4] scsi: ufs: core: Factor hba->outstanding_reqs helper and fix double completion Stanley Jhu
2026-10-17 8:44 ` [PATCH v2 1/4] scsi: ufs: core: Add a helper for clearing hba->outstanding_reqs Stanley Jhu
2026-10-19 20:50 ` Bart Van Assche
2026-10-17 8:44 ` [PATCH v2 2/4] scsi: ufs: core: Fix double completion in ufshcd_clear_lu_cmds() Stanley Jhu
2026-10-17 8:44 ` [PATCH v2 3/4] scsi: ufs: core: Use ufshcd_clear_outstanding_reqs() in ufshcd_eh_timed_out() Stanley Jhu
2026-10-17 8:44 ` [PATCH v2 4/4] scsi: ufs: core: Remove an always-false WARN_ONCE() Stanley Jhu
2026-10-19 20:45 ` Bart Van Assche [this message]
2026-10-18 19:52 ` [PATCH v2 0/4] scsi: ufs: core: Factor hba->outstanding_reqs helper and fix double completion Bean Huo
2026-10-19 4:29 ` Stanley Jhu
2026-10-19 20:43 ` Bart Van Assche
2026-10-20 3:16 ` Peter Wang
2026-10-20 8:27 ` Stanley Jhu
2026-10-20 16:46 ` Bart Van Assche
2026-10-20 20:22 ` Bart Van Assche
2026-10-19 10:47 ` Peter Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ef38c72-9288-4d33-9f42-439c9dbd01d4@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=beanhuo@micron.com \
--cc=can.guo@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=peter.wang@mediatek.com \
--cc=stable@vger.kernel.org \
--cc=stanleyjhu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®