mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Wang <peter.wang@mediatek.com>
To: Bart Van Assche <bvanassche@acm.org>, Bean Huo <beanhuo@iokpp.de>,
	Stanley Jhu <stanleyjhu@google.com>,
	"Martin K . Petersen" <mkp@kernel.org>,
	<linux-scsi@vger.kernel.org>
Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	Bean Huo <beanhuo@micron.com>, Can Guo <can.guo@oss.qualcomm.com>,
	<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] scsi: ufs: core: Factor hba->outstanding_reqs helper and fix double completion
Date: Tue, 20 Oct 2026 11:16:25 +0800	[thread overview]
Message-ID: <78888420b7c60d2d5177cbf76f5efba04fab5d7b.camel@mediatek.com> (raw)
In-Reply-To: <2060a8da-581b-46d1-a510-779f4df716cd@acm.org>

On Mon, 2026-10-19 at 13:43 -0700, Bart Van Assche wrote:
> Hi Bean,
> 
> There are two problems with calling ufshcd_compl_one_cqe() from
> ufshcd_abort():
> * ufshcd_compl_one_cqe() must only be called for SCSI commands while
>    'tag' may refer to a device management command.
> * SCSI commands must not be freed by a SCSI abort handler. Otherwise
>    a use-after-free may be triggered in scmd_eh_abort_handler() when
> it
>    tries to call scsi_queue_insert() or scsi_finish_command().
> 
> Bart.

Hi Bart,

So, should we remove the call to __ufshcd_transfer_req_compl from 
ufshcd_abort, which was added by commit 
64180742605f (“scsi: ufs: Fix the SCSI abort handler”)?

Thanks.
Peter


  reply	other threads:[~2026-10-20  3:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  8:43 Stanley Jhu
2026-10-17  8:44 ` [PATCH v2 1/4] scsi: ufs: core: Add a helper for clearing hba->outstanding_reqs Stanley Jhu
2026-10-19 20:50   ` Bart Van Assche
2026-10-17  8:44 ` [PATCH v2 2/4] scsi: ufs: core: Fix double completion in ufshcd_clear_lu_cmds() Stanley Jhu
2026-10-17  8:44 ` [PATCH v2 3/4] scsi: ufs: core: Use ufshcd_clear_outstanding_reqs() in ufshcd_eh_timed_out() Stanley Jhu
2026-10-17  8:44 ` [PATCH v2 4/4] scsi: ufs: core: Remove an always-false WARN_ONCE() Stanley Jhu
2026-10-19 20:45   ` Bart Van Assche
2026-10-18 19:52 ` [PATCH v2 0/4] scsi: ufs: core: Factor hba->outstanding_reqs helper and fix double completion Bean Huo
2026-10-19  4:29   ` Stanley Jhu
2026-10-19 20:43   ` Bart Van Assche
2026-10-20  3:16     ` Peter Wang [this message]
2026-10-20  8:27       ` Stanley Jhu
2026-10-20 16:46       ` Bart Van Assche
2026-10-19 10:47 ` Peter Wang
2026-10-20  3:15 Peter Wang (王信友)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78888420b7c60d2d5177cbf76f5efba04fab5d7b.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=beanhuo@iokpp.de \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stanleyjhu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®