From: Sudeep Holla <sudeep.holla@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Sudeep Holla <sudeep.holla@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init
Date: Mon, 13 Nov 2017 15:10:49 +0000 [thread overview]
Message-ID: <6ef431ab-54c4-00c3-852a-7e448ccaa837@arm.com> (raw)
In-Reply-To: <6cdbbe9b-309a-7cb9-648f-7df2295c510f@linaro.org>
On 13/11/17 14:58, Daniel Lezcano wrote:
> On 13/11/2017 11:11, Sudeep Holla wrote:
[..]
>>
>> Agreed, may be if we add users which is called from init functions, the
>> warning should disappear. Also as tglx suggested, we could rename if it's
>> just used from init function error/exit paths.
>
> The drivers are not compiled as module AFAICT, the function will be
> called in the init error path.
>
Understood, IMO better to rename the functions as cleanup or something
similar. exit made it sound differently and since there were no users,
I assumed it to be used in remove/exit functions. Sorry for the noise.
--
Regards,
Sudeep
prev parent reply other threads:[~2017-11-13 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 13:34 Arnd Bergmann
2017-11-12 21:16 ` Thomas Gleixner
2017-11-12 22:24 ` Arnd Bergmann
2017-11-12 22:27 ` Thomas Gleixner
2017-11-13 9:27 ` Benjamin Gaignard
2017-11-13 10:11 ` Sudeep Holla
2017-11-13 14:58 ` Daniel Lezcano
2017-11-13 15:10 ` Thomas Gleixner
2017-11-13 15:10 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ef431ab-54c4-00c3-852a-7e448ccaa837@arm.com \
--to=sudeep.holla@arm.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®