mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay
@ 2024-03-08 12:41 Viken Dadhaniya
  2024-03-12  0:15 ` Konrad Dybcio
  2024-04-11  9:45 ` Srinivas Kandagatla
  0 siblings, 2 replies; 3+ messages in thread
From: Viken Dadhaniya @ 2024-03-08 12:41 UTC (permalink / raw)
  To: andersson, konrad.dybcio, srinivas.kandagatla, linux-arm-msm,
	alsa-devel, linux-kernel
  Cc: quic_msavaliy, quic_vtanuku, quic_anupkulk, quic_cchiluve,
	Viken Dadhaniya

Currently we have auto suspend delay of 1s which is
very high and it takes long time to driver for runtime
suspend after use case is done.

Hence to optimize runtime PM ops, reduce auto suspend
delay to 100ms.

Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
---
v1 -> v2:
- Remove macro and add value inline.
- Link to v1: https://lore.kernel.org/linux-arm-msm/d784e46d-974d-4bf3-a2d3-491e7ad19701@linaro.org/T/
---
---
 drivers/slimbus/qcom-ngd-ctrl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index efeba8275a66..5e132273c6c4 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -81,7 +81,6 @@
 #define SLIM_USR_MC_DISCONNECT_PORT	0x2E
 #define SLIM_USR_MC_REPEAT_CHANGE_VALUE	0x0
 
-#define QCOM_SLIM_NGD_AUTOSUSPEND	MSEC_PER_SEC
 #define SLIM_RX_MSGQ_TIMEOUT_VAL	0x10000
 
 #define SLIM_LA_MGR	0xFF
@@ -1571,7 +1570,7 @@ static int qcom_slim_ngd_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, ctrl);
 	pm_runtime_use_autosuspend(dev);
-	pm_runtime_set_autosuspend_delay(dev, QCOM_SLIM_NGD_AUTOSUSPEND);
+	pm_runtime_set_autosuspend_delay(dev, 100);
 	pm_runtime_set_suspended(dev);
 	pm_runtime_enable(dev);
 	pm_runtime_get_noresume(dev);
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay
  2024-03-08 12:41 [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay Viken Dadhaniya
@ 2024-03-12  0:15 ` Konrad Dybcio
  2024-04-11  9:45 ` Srinivas Kandagatla
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-03-12  0:15 UTC (permalink / raw)
  To: Viken Dadhaniya, andersson, srinivas.kandagatla, linux-arm-msm,
	alsa-devel, linux-kernel
  Cc: quic_msavaliy, quic_vtanuku, quic_anupkulk, quic_cchiluve



On 3/8/24 13:41, Viken Dadhaniya wrote:
> Currently we have auto suspend delay of 1s which is
> very high and it takes long time to driver for runtime
> suspend after use case is done.
> 
> Hence to optimize runtime PM ops, reduce auto suspend
> delay to 100ms.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay
  2024-03-08 12:41 [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay Viken Dadhaniya
  2024-03-12  0:15 ` Konrad Dybcio
@ 2024-04-11  9:45 ` Srinivas Kandagatla
  1 sibling, 0 replies; 3+ messages in thread
From: Srinivas Kandagatla @ 2024-04-11  9:45 UTC (permalink / raw)
  To: andersson, konrad.dybcio, linux-arm-msm, alsa-devel,
	linux-kernel, Viken Dadhaniya
  Cc: quic_msavaliy, quic_vtanuku, quic_anupkulk, quic_cchiluve


On Fri, 08 Mar 2024 18:11:29 +0530, Viken Dadhaniya wrote:
> Currently we have auto suspend delay of 1s which is
> very high and it takes long time to driver for runtime
> suspend after use case is done.
> 
> Hence to optimize runtime PM ops, reduce auto suspend
> delay to 100ms.
> 
> [...]

Applied, thanks!

[1/1] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay
      commit: 5e8e32f818138fff0087d7a9708806db49b650a4

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-11  9:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 12:41 [PATCH v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay Viken Dadhaniya
2024-03-12  0:15 ` Konrad Dybcio
2024-04-11  9:45 ` Srinivas Kandagatla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®