mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: David Heidelberg <david@ixit.cz>,
	longnoserob@gmail.com, Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
Date: Fri, 5 Dec 2025 14:50:23 +0100	[thread overview]
Message-ID: <6f085aee-e1a3-4171-822e-1ad4f963515a@oss.qualcomm.com> (raw)
In-Reply-To: <5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz>

On 12/5/25 2:45 PM, David Heidelberg wrote:
> On 05/12/2025 14:27, Konrad Dybcio wrote:
> 
> [...]
> 
>>> @@ -637,3 +643,4 @@ &wifi {
>>>       vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>>>       vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>>>   };
>>> +
>>>
>>
>> Stray hunk?
> 
> I think your comment goes into the category of "extreme nitpicks".
> 
> Here as usual I guess there are three options:
>  - another revision because of newline
>  - maintainer merge it with it and nothing happens
>  - while merge, maintainer remove the line

$ LC_ALL=C b4 shazam 5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz -P 1

Grabbing thread from lore.kernel.org/all/5b1ad72d-bd85-4950-8148-266296a05db1@ixit.cz/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 6 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
  [PATCH v2 1/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
  ---
  ✗ No key: openpgp/longnoserob@gmail.com
---
Total patches: 1 (cherrypicked: 1)
---
 Base: using specified base-commit 6987d58a9cbc5bd57c983baa514474a86c945d56
Applying: arm64: dts: qcom: sdm845-xiaomi-beryllium: Enable SLPI
/<snip path>/.git/rebase-apply/patch:26: new blank line at EOF.
+
warning: 1 line adds whitespace errors.


It works best when both submitters and maintainers check their work..

Konrad

  reply	other threads:[~2025-12-05 13:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 13:00 [PATCH v2 0/3] " Robert Eckelmann via B4 Relay
2025-12-05 13:00 ` [PATCH v2 1/3] " Robert Eckelmann via B4 Relay
2025-12-05 13:27   ` Konrad Dybcio
2025-12-05 13:45     ` David Heidelberg
2025-12-05 13:50       ` Konrad Dybcio [this message]
2025-12-05 13:00 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Adjust firmware paths Robert Eckelmann via B4 Relay
2025-12-05 13:00 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add placeholders and sort Robert Eckelmann via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f085aee-e1a3-4171-822e-1ad4f963515a@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longnoserob@gmail.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®